OCPBUGS-46361: Mark adm pod-network command as hidden and depcated

[ardaguclu]

oc adm pod-network command only works on OpenShift SDN which has been deprecated long time ago. So still advertising this command in help output is misleading.

This PR marks this command as hidden, so oc adm --help will not print it. Besides, this PR marks this command as deprecated, so there will be a deprecation message during its usage.

$ ./oc adm pod-network
Command "pod-network" is deprecated, pod-network command only works on OpenShift SDN which has been deprecated.
Manage pod network in the cluster

Other than that, users still rely on the functionality of this command will continue using it as is (just an additional deprecation message that should not cause any issues).

[openshift-ci-robot]

@ardaguclu: This pull request references Jira Issue OCPBUGS-46361, which is invalid:

• expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

oc adm pod-network command only works on OpenShift SDN which has been deprecated long time ago. So still advertising this command in help output is misleading.

This PR marks this command as hidden, so oc adm --help will not print it. Besides, this PR marks this command as deprecated, so there will be a deprecation message during its usage.

$ ./oc adm pod-network
Command "pod-network" is deprecated, pod-network command only works on OpenShift SDN which has been deprecated.
Manage pod network in the cluster

Other than that, users still rely on the functionality of this command will continue using it as is (just an additional deprecation message that should not cause any issues).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ardaguclu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ardaguclu]

@danwinship does this deprecation message make sense?.

[ardaguclu]

/jira refresh

[openshift-ci-robot]

@ardaguclu: This pull request references Jira Issue OCPBUGS-46361, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.19.0) matches configured target version for branch (4.19.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @zhouying7780

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[ardaguclu]

/retest

[openshift-ci]

@ardaguclu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	b8ea41b	link	false	/test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[danwinship]

sure, lgtm

[zhouying7780]

/label qe-approved

[openshift-ci-robot]

@ardaguclu: This pull request references Jira Issue OCPBUGS-46361, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.19.0) matches configured target version for branch (4.19.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @zhouying7780

In response to this:

oc adm pod-network command only works on OpenShift SDN which has been deprecated long time ago. So still advertising this command in help output is misleading.

This PR marks this command as hidden, so oc adm --help will not print it. Besides, this PR marks this command as deprecated, so there will be a deprecation message during its usage.

$ ./oc adm pod-network
Command "pod-network" is deprecated, pod-network command only works on OpenShift SDN which has been deprecated.
Manage pod network in the cluster

Other than that, users still rely on the functionality of this command will continue using it as is (just an additional deprecation message that should not cause any issues).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.