Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WORK IN PROGRESS: Add a new command on oc adm to generate the communication matrix #1925

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

aabughosh
Copy link

No description provided.

@openshift-ci openshift-ci bot requested review from ardaguclu and deads2k November 26, 2024 13:58
Copy link
Contributor

openshift-ci bot commented Nov 26, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aabughosh
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aabughosh aabughosh changed the title Added a new command on oc adm to generate the communication matrix WORK IN PROGRESS: Add a new command on oc adm to generate the communication matrix Nov 26, 2024
@ardaguclu
Copy link
Member

@aabughosh thanks for the PR. Our policy is to deliver these kind of commands in separate plugins rather than adding them into oc as builtin commands. You can have a look at other plugins in https://krew.sigs.k8s.io/plugins/.

@ardaguclu
Copy link
Member

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 26, 2024
Copy link
Contributor

openshift-ci bot commented Nov 26, 2024

@aabughosh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-serial 7d5d5d7 link true /test e2e-aws-ovn-serial
ci/prow/e2e-aws-ovn 7d5d5d7 link true /test e2e-aws-ovn
ci/prow/verify-deps 7d5d5d7 link true /test verify-deps
ci/prow/e2e-metal-ipi-ovn-ipv6 7d5d5d7 link false /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-aws-ovn-upgrade 7d5d5d7 link true /test e2e-aws-ovn-upgrade
ci/prow/images 7d5d5d7 link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants