Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include must-gather image name in ENV #1842

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

black-dragon74
Copy link
Member

The request for such feature came from a Bugzilla
for odf-must-gather.

We want the must-gather containers to be able to check the image being used. This is useful in cases where we want to deduce if the customer is using the image we ask them to.

While it is possible to call the k8s API internally (this is how it is implemented currently for odf-mg), it would be much efficient if the value is present inside the container as an ENV.

This patch sets an ENV var MUST_GATHER_IMAGE to reflect the image source of the pods.

Regards

The request for such feature came from a Bugzilla
for odf-must-gather.

We want the must-gather containers to be able to check the
image being used. This is useful in cases where we want to
deduce if the customer is using the image we ask them to.

While it is possible to call the k8s API internally (this is
how it is implemented currently for odf-mg), it would be much
efficient if the value is present inside the container as an ENV.

This patch sets an ENV var `MUST_GATHER_IMAGE` to reflect the
image source of the pods.

Signed-off-by: Niraj Yadav <[email protected]>
@openshift-ci openshift-ci bot requested review from ardaguclu and soltysh August 8, 2024 08:23
Copy link
Contributor

openshift-ci bot commented Aug 8, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: black-dragon74
Once this PR has been reviewed and has the lgtm label, please assign soltysh for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Aug 8, 2024

@black-dragon74: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images a02f9cf link true /test images
ci/prow/verify a02f9cf link true /test verify
ci/prow/rpm-build a02f9cf link true /test rpm-build
ci/prow/security a02f9cf link false /test security
ci/prow/unit a02f9cf link true /test unit
ci/prow/build-rpms-from-tar a02f9cf link true /test build-rpms-from-tar
ci/prow/e2e-agnostic-ovn-cmd a02f9cf link true /test e2e-agnostic-ovn-cmd
ci/prow/verify-deps a02f9cf link true /test verify-deps

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@black-dragon74
Copy link
Member Author

PTAL @ardaguclu @soltysh

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants