Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[oadp-1.4] OADP-4379: read ephemeral-storage in code #1491

Merged

Conversation

mateusoliveira43
Copy link
Contributor

Why the changes were made

cherry picked from commit b51ce21 : PR #1477

How to test the changes made

Follow instructions from parent PR.

Signed-off-by: Mateus Oliveira <[email protected]>
(cherry picked from commit b51ce21)
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 14, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 14, 2024

@mateusoliveira43: This pull request references OADP-4379 which is a valid jira issue.

In response to this:

Why the changes were made

cherry picked from commit b51ce21 : PR #1477

How to test the changes made

Follow instructions from parent PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mateusoliveira43
Copy link
Contributor Author

/retest

@mateusoliveira43
Copy link
Contributor Author

/retest
infra and post restore flake

@mateusoliveira43
Copy link
Contributor Author

/retest

1 similar comment
@mateusoliveira43
Copy link
Contributor Author

/retest

Copy link

openshift-ci bot commented Aug 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mateusoliveira43, shubham-pampattiwar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [shubham-pampattiwar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 14, 2024
@weshayutin
Copy link
Contributor

/retest

Copy link
Contributor

@weshayutin weshayutin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@weshayutin
Copy link
Contributor

hrm... this doesn't seem like a "flake" more like build / containers aren't right, but unrelated to this patch.

@mateusoliveira43
Copy link
Contributor Author

/retest

3 similar comments
@mateusoliveira43
Copy link
Contributor Author

/retest

@mateusoliveira43
Copy link
Contributor Author

/retest

@mateusoliveira43
Copy link
Contributor Author

/retest

Copy link

openshift-ci bot commented Aug 15, 2024

@mateusoliveira43: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@shubham-pampattiwar
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 59157e8 into openshift:oadp-1.4 Aug 15, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants