OADP-4076: Add qps and burst to DPA

[mateusoliveira43]

Why the changes were made

In Velero 1.14, Burst and QPS will change defaults from 30 and 20 to 100 and 100.
References:

• vmware-tanzu/velero@d676bfd
• 1.13 code https://github.com/vmware-tanzu/velero/blob/release-1.13/pkg/cmd/server/server.go#L93
• 1.14 code https://github.com/vmware-tanzu/velero/blob/release-1.14/pkg/cmd/server/server.go#L96

This PR ensures OADP users can change it.

How to test the changes made

Create DPA with new fields and check if values are passed to Velero container.

[openshift-ci-robot]

@mateusoliveira43: This pull request references OADP-4076 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

In response to this:

Why the changes were made

In Velero 1.14, Burst and QPS will change defaults from 30 and 20 to 100 and 100. Reference: vmware-tanzu/velero@d676bfd

This PR ensures OADP users still use the same values, if they do not want to change it.

How to test the changes made

Create DPA with:

• new fields and check if values are passed to Velero container
• without new fields and check if default values are passed to Velero container

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@mateusoliveira43: This pull request references OADP-4076 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

In response to this:

Why the changes were made

In Velero 1.14, Burst and QPS will change defaults from 30 and 20 to 100 and 100.
References:

• vmware-tanzu/velero@d676bfd
• 1.13 code https://github.com/vmware-tanzu/velero/blob/release-1.13/pkg/cmd/server/server.go#L93
• 1.14 code https://github.com/vmware-tanzu/velero/blob/release-1.14/pkg/cmd/server/server.go#L96

This PR ensures OADP users still use the same values, if they do not want to change it.

How to test the changes made

Create DPA with:

• new fields and check if values are passed to Velero container
• without new fields and check if default values are passed to Velero container

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@mateusoliveira43: This pull request references OADP-4076 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

In response to this:

Why the changes were made

In Velero 1.14, Burst and QPS will change defaults from 30 and 20 to 100 and 100.
References:

• vmware-tanzu/velero@d676bfd
• 1.13 code https://github.com/vmware-tanzu/velero/blob/release-1.13/pkg/cmd/server/server.go#L93
• 1.14 code https://github.com/vmware-tanzu/velero/blob/release-1.14/pkg/cmd/server/server.go#L96

This PR ensures OADP users can change it.

How to test the changes made

Create DPA with new fields and check if values are passed to Velero container.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@mateusoliveira43: Overrode contexts on behalf of mateusoliveira43: ci/prow/4.16-e2e-test-aws

In response to this:

/override ci/prow/4.16-e2e-test-aws
restore succeeds, but deployment/deploymentConfig never goes to ready state flake

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

@mateusoliveira43: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/4.12-e2e-test-aws	5b38fe3	link	true	/test 4.12-e2e-test-aws
ci/prow/4.13-ci-index	5b38fe3	link	true	/test 4.13-ci-index

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[mateusoliveira43]

/override ci/prow/4.15-e2e-test-aws
restore succeeds, but deployment/deploymentConfig never goes to ready state flake

[openshift-ci]

@mateusoliveira43: Overrode contexts on behalf of mateusoliveira43: ci/prow/4.15-e2e-test-aws

In response to this:

/override ci/prow/4.15-e2e-test-aws
restore succeeds, but deployment/deploymentConfig never goes to ready state flake

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[shubham-pampattiwar]

Looks good !

shubham@fedora ~/oadp-operator -  (mateus-qps) $ oc get po velero-5d9b8546f4-trn26 -oyaml | grep args -7
    kind: ReplicaSet
    name: velero-5d9b8546f4
    uid: 8a40bfaa-fde7-4428-8e7b-f91a29330db3
  resourceVersion: "10670511"
  uid: 78de38b8-3e88-4295-9278-388c270dca47
spec:
  containers:
  - args:
    - server
    - --features=EnableCSI
    - --uploader-type=kopia
    - --fs-backup-timeout=4h
    - --restore-resource-priorities=securitycontextconstraints,customresourcedefinitions,klusterletconfigs.config.open-cluster-management.io,managedcluster.cluster.open-cluster-management.io,namespaces,roles,rolebindings,clusterrolebindings,klusterletaddonconfig.agent.open-cluster-management.io,managedclusteraddon.addon.open-cluster-management.io,storageclasses,volumesnapshotclass.snapshot.storage.k8s.io,volumesnapshotcontents.snapshot.storage.k8s.io,volumesnapshots.snapshot.storage.k8s.io,datauploads.velero.io,persistentvolumes,persistentvolumeclaims,serviceaccounts,secrets,configmaps,limitranges,pods,replicasets.apps,clusterclasses.cluster.x-k8s.io,endpoints,services,-,clusterbootstraps.run.tanzu.vmware.com,clusters.cluster.x-k8s.io,clusterresourcesets.addons.cluster.x-k8s.io
    - --client-burst=700
    - --client-qps=111
shubham@fedora ~/oadp-operator -  (mateus-qps) $ oc get dpa ts-dpa -oyaml | grep client
      client-burst: 700
      client-qps: 111
shubham@fedora ~/oadp-operator -  (mateus-qps) $ 

[weshayutin]

/LGTM

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mateusoliveira43, shubham-pampattiwar, weshayutin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mateusoliveira43,shubham-pampattiwar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[shubham-pampattiwar]

/cherry-pick 1.4

[shubham-pampattiwar]

/cherry-pick oadp-1.4

[openshift-cherrypick-robot]

@shubham-pampattiwar: cannot checkout 1.4: error checking out "1.4": exit status 1 error: pathspec '1.4' did not match any file(s) known to git

In response to this:

/cherry-pick 1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-cherrypick-robot]

@shubham-pampattiwar: #1395 failed to apply on top of branch "oadp-1.4":

Applying: fix: Default value of qps and burst
Using index info to reconstruct a base tree...
M	Makefile
M	api/v1alpha1/oadp_types.go
M	api/v1alpha1/zz_generated.deepcopy.go
M	bundle/manifests/oadp.openshift.io_dataprotectionapplications.yaml
M	config/crd/bases/oadp.openshift.io_dataprotectionapplications.yaml
M	controllers/velero.go
M	controllers/velero_test.go
Falling back to patching base and 3-way merge...
Auto-merging controllers/velero_test.go
Auto-merging controllers/velero.go
Auto-merging config/crd/bases/oadp.openshift.io_dataprotectionapplications.yaml
Auto-merging bundle/manifests/oadp.openshift.io_dataprotectionapplications.yaml
Auto-merging api/v1alpha1/zz_generated.deepcopy.go
Auto-merging api/v1alpha1/oadp_types.go
Auto-merging Makefile
CONFLICT (content): Merge conflict in Makefile
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 fix: Default value of qps and burst
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick oadp-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.