fix: Remove and relocate files #1246

mateusoliveira43 · 2023-11-30T12:24:07Z

Remove unused files and relocate files that were alone in folders.

openshift-ci · 2023-11-30T12:25:08Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

mateusoliveira43 · 2023-11-30T12:25:38Z

.github/workflows/docs-actions.yml

Unfortunately we do not have GitHub actions in this repo, so these files are not used

Except from the link checker job, I think the rest is already done by PROW

Isn't that still relevant for people (like doc's team) which would want to setup such workflows on the forked repos? openshift org doesn't allow GitHub Actions, however on a forked oadp-operator we can have them.

I have in the past setup codecov workflows to run in forks. Have thrown ideas in the ring for having GHActions do code formatting in forks which would indirectly update PRs.. but people didn't like the idea of having code updated without their knowledge.

Not just docs.

.travis.yml

mateusoliveira43 · 2023-11-30T12:27:17Z

Makefile

@@ -318,9 +318,6 @@ bundle: manifests kustomize operator-sdk ## Generate bundle manifests and metada
 	cd config/manager && GOFLAGS="-mod=mod" $(KUSTOMIZE) edit set image controller=$(IMG)
 	GOFLAGS="-mod=mod" $(KUSTOMIZE) build config/manifests | GOFLAGS="-mod=mod" $(OPERATOR_SDK) generate bundle -q --extra-service-accounts "velero" --overwrite --version $(VERSION) $(BUNDLE_METADATA_OPTS)
 	@make nullables
-	# Copy updated bundle.Dockerfile to CI's Dockerfile.bundle
-	# TODO: update CI to use generated one
-	cp bundle.Dockerfile build/Dockerfile.bundle


@shubham-pampattiwar Can you confirm this is not needed? (we could also remove the doc file I modified)

Usually most of that Makefile is generated by operator-sdk, did you experiment with creating new one or upgrading to the newer version of operator-sdk and re-generating Makefile?

yes, we modified it https://github.com/operator-framework/operator-sdk/blob/e001847a67f16d7173ae4fee7cff57cd4405edbb/internal/plugins/manifests/v2/init.go#L223-L238

mateusoliveira43 · 2023-11-30T12:28:10Z

OWNERS_ALIASES

To use this, we would need to cite the team name in OWNERS
Reference https://github.com/kubernetes/community/blob/master/contributors/guide/owners.md

mateusoliveira43 · 2023-11-30T12:28:56Z

docs/design/upstream-datamover.md

@@ -66,7 +66,7 @@ The new velero `DataUpload` and `DataDownload` will be added.

 #### OADP container images

-References to `velero-plugin-for-vsm` and `volume-snapshot-mover` images need to be removed from `config/manager/manager.yaml`, golang code, and `deploy/disconnected-prep.sh`.
+References to `velero-plugin-for-vsm` and `volume-snapshot-mover` images need to be removed from `config/manager/manager.yaml`, golang code, and `scripts/disconnected-prep.sh`.


Maybe would also need changes in prod docs

maybe not? https://github.com/search?q=repo%3Aopenshift%2Fopenshift-docs+disconnected-prep&type=code Is there other places our docs live?

mateusoliveira43 · 2023-11-30T12:29:15Z

scripts/ci.Dockerfile

This would also need PROW changes

gave up in the idea on this PR, for simplicity, but could be a valid change in the future

mateusoliveira43 · 2023-11-30T12:30:55Z

scripts/disconnected-prep.sh

would also want to move docs/examples/datamover_resources.sh, docs/scripts/dc-post-restore.sh files and blogs/tekton-oadp-nonadmin/, must-gather/ folders inside this new folder

and move blogs/ folder inside docs/ folder

scripts/boilerplate.go.txt

mpryc · 2023-12-06T15:22:54Z

build/Dockerfile.bundle

Isn't this file generated by operator-sdk operator-sdk generate bundle ?

no, operator-sdk generates bundle.Dockerfile in the project root. This one is copy of it

Maybe downstream build requires that? Please double check with release engineering. And if needed maybe a symlink instead of raw copy?

No the build/....Dockerfiles were mostly for CI/prow related mods to run e2e/unit tests.

mateusoliveira43 · 2023-12-29T16:25:35Z

/retest

mateusoliveira43 · 2023-12-29T16:56:36Z

build/Dockerfile.bundle

This is used by CI... https://github.com/openshift/release/blob/master/ci-operator/config/openshift/oadp-operator/openshift-oadp-operator-master__4.12.yaml#L15

lets revert this change if CI uses this file

reverted. The details are in the issue, so it can be done later in another PR

mateusoliveira43 · 2023-12-29T16:57:36Z

/hold

Discuss change in CI files (that would also need changes in all tested branches)

mateusoliveira43 · 2024-01-16T13:38:12Z

/unhold

Signed-off-by: Mateus Oliveira <[email protected]>

weshayutin

/lgtm

openshift-ci · 2024-03-08T17:59:59Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mateusoliveira43, weshayutin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [mateusoliveira43]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2024-03-08T20:45:59Z

/retest-required

Remaining retests: 0 against base HEAD 355cf0f and 2 for PR HEAD 827d576 in total

mateusoliveira43 · 2024-03-11T12:14:21Z

/override ci/prow/4.13-e2e-test-aws
/override ci/prow/4.14-e2e-test-azure
both were successful restore but application not working after

openshift-ci · 2024-03-11T12:16:40Z

@mateusoliveira43: Overrode contexts on behalf of mateusoliveira43: ci/prow/4.13-e2e-test-aws, ci/prow/4.14-e2e-test-azure

In response to this:

/override ci/prow/4.13-e2e-test-aws
/override ci/prow/4.14-e2e-test-azure
both were successful restore but application not working after

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2024-03-11T12:16:44Z

@mateusoliveira43: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 30, 2023

mateusoliveira43 commented Nov 30, 2023

View reviewed changes

.travis.yml Outdated Show resolved Hide resolved

mateusoliveira43 commented Nov 30, 2023

View reviewed changes

mateusoliveira43 commented Dec 1, 2023

View reviewed changes

scripts/boilerplate.go.txt Outdated Show resolved Hide resolved

mpryc reviewed Dec 6, 2023

View reviewed changes

mateusoliveira43 force-pushed the fix/remove-realocate-files branch from 926e270 to 6ce23e0 Compare December 28, 2023 14:05

mateusoliveira43 marked this pull request as ready for review December 28, 2023 15:34

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 28, 2023

openshift-ci bot requested review from shubham-pampattiwar and sseago December 28, 2023 15:35

mateusoliveira43 force-pushed the fix/remove-realocate-files branch from f8691c8 to 0aa055c Compare December 29, 2023 16:48

mateusoliveira43 commented Dec 29, 2023

View reviewed changes

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 29, 2023

mateusoliveira43 mentioned this pull request Dec 29, 2023

remove build/ folder #1259

Open

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 16, 2024

mateusoliveira43 added 2 commits March 8, 2024 14:52

fix: Remove and realocate files

74aaf3e

Signed-off-by: Mateus Oliveira <[email protected]>

fixup! fix: Fix codecov post job (openshift#1255)

827d576

Signed-off-by: Mateus Oliveira <[email protected]>

mateusoliveira43 force-pushed the fix/remove-realocate-files branch from 1441531 to 827d576 Compare March 8, 2024 17:53

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2024

weshayutin approved these changes Mar 8, 2024

View reviewed changes

openshift-ci bot assigned weshayutin Mar 8, 2024

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 8, 2024

openshift-merge-bot bot merged commit 7cf1ba9 into openshift:master Mar 11, 2024
16 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Remove and relocate files #1246

fix: Remove and relocate files #1246

mateusoliveira43 commented Nov 30, 2023

openshift-ci bot commented Nov 30, 2023

mateusoliveira43 Nov 30, 2023

mpryc Dec 6, 2023

kaovilai Dec 6, 2023

mateusoliveira43 Nov 30, 2023

mpryc Dec 6, 2023

mateusoliveira43 Dec 6, 2023

mateusoliveira43 Nov 30, 2023

mateusoliveira43 Nov 30, 2023

mateusoliveira43 Dec 28, 2023

mateusoliveira43 Nov 30, 2023

mateusoliveira43 Dec 28, 2023

mateusoliveira43 Nov 30, 2023

mpryc Dec 6, 2023

mateusoliveira43 Dec 6, 2023

mpryc Dec 6, 2023

kaovilai Dec 6, 2023

mateusoliveira43 commented Dec 29, 2023

mateusoliveira43 Dec 29, 2023

shubham-pampattiwar Jan 15, 2024

mateusoliveira43 Jan 16, 2024

mateusoliveira43 commented Dec 29, 2023

mateusoliveira43 commented Jan 16, 2024

weshayutin left a comment

openshift-ci bot commented Mar 8, 2024

openshift-ci-robot commented Mar 8, 2024

mateusoliveira43 commented Mar 11, 2024

openshift-ci bot commented Mar 11, 2024

openshift-ci bot commented Mar 11, 2024

fix: Remove and relocate files #1246

fix: Remove and relocate files #1246

Conversation

mateusoliveira43 commented Nov 30, 2023

openshift-ci bot commented Nov 30, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mateusoliveira43 commented Dec 29, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mateusoliveira43 commented Dec 29, 2023

mateusoliveira43 commented Jan 16, 2024

weshayutin left a comment

Choose a reason for hiding this comment

openshift-ci bot commented Mar 8, 2024

openshift-ci-robot commented Mar 8, 2024

mateusoliveira43 commented Mar 11, 2024

openshift-ci bot commented Mar 11, 2024

openshift-ci bot commented Mar 11, 2024