-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update command list to apply NODE_NAME env var correctly #101
base: master
Are you sure you want to change the base?
Conversation
We had an issue when deploying the daemon set and found the `NODE_NAME` was not translated correctly through args. Consequently the network-metrics-daemon pods was unable to properly execute as the environment variable was nullified. By utilizing a different command method, the pod is now able to retrieve the `NODE_NAME` env variable. Running on 8 nodes, version `v1.29.4+rke2r1`.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akhan23wgu The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @akhan23wgu. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/approve |
/ok-to-test |
@akhan23wgu: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
We had an issue when deploying the daemon set and found the
NODE_NAME
was not translated correctly through args. Consequently the network-metrics-daemon pods was unable to properly execute as the environment variable was nullified.By utilizing a different command method, the pod is now able to retrieve the
NODE_NAME
env variable.Running on 8 nodes, version
v1.29.4+rke2r1
.