Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update command list to apply NODE_NAME env var correctly #101

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

akhan23wgu
Copy link

@akhan23wgu akhan23wgu commented Aug 2, 2024

We had an issue when deploying the daemon set and found the NODE_NAME was not translated correctly through args. Consequently the network-metrics-daemon pods was unable to properly execute as the environment variable was nullified.

By utilizing a different command method, the pod is now able to retrieve the NODE_NAME env variable.

Running on 8 nodes, version v1.29.4+rke2r1.

We had an issue when deploying the daemon set and found the `NODE_NAME` was not translated correctly through args. Consequently the network-metrics-daemon pods was unable to properly execute as the environment variable was nullified.

By utilizing a different command method, the pod is now able to retrieve the `NODE_NAME` env variable.

Running on 8 nodes, version `v1.29.4+rke2r1`.
@openshift-ci openshift-ci bot requested review from dougbtv and fedepaol August 2, 2024 16:43
Copy link

openshift-ci bot commented Aug 2, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akhan23wgu
Once this PR has been reviewed and has the lgtm label, please assign dougbtv for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 2, 2024
Copy link

openshift-ci bot commented Aug 2, 2024

Hi @akhan23wgu. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pliurh
Copy link
Contributor

pliurh commented Sep 20, 2024

/approve

@pliurh
Copy link
Contributor

pliurh commented Sep 20, 2024

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 20, 2024
Copy link

openshift-ci bot commented Sep 20, 2024

@akhan23wgu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 1a4cce6 link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants