MULTIARCH-5181: pod-level circuit-breaking for image registry inspection errors #377
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
aleskandro
force-pushed
the
circuit-breaker-1
branch
2 times, most recently
from
72a6e39 to
37079cc
Compare
aleskandro
force-pushed
the
circuit-breaker-1
branch
from
37079cc to
8cd9225
Compare
|
/retest-required |
| _, err = pod.SetNodeAffinityArchRequirement(psdl) | ||
| pod.handleError(err, "Unable to set the node affinity for the pod.") | ||
| } | ||
| if pod.maxRetries() && err != nil { |
There was a problem hiding this comment.
one worry i have is that we might get rate limited by the registry if it is slow..maybe a backoff of sorts would be good to implement.. i.e, if the same pod is again queued, we might want to give it some time
There was a problem hiding this comment.
Hi @Prashanth684 the (exponential) backoff is already implemented through the controller-runtime facilities.
aleskandro
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
openshift-ci-robot
added
the
jira/valid-reference
|
@aleskandro: This pull request references MULTIARCH-5181 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aleskandro The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@aleskandro: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
No description provided.