-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(route-monitor-operator): add console monitor [OSD-5499] #736
Merged
openshift-merge-robot
merged 18 commits into
openshift:master
from
georgettica:georgettica/add-rmo-files
Apr 7, 2021
Merged
Changes from 13 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
f00ebaf
chore(route-monitor-operator): add console monitor
georgettica fb344ad
on push: make
georgettica 0d603c2
Delete OWNERS
georgettica 5858304
Update deploy/osd-route-monitor-operator/100-rmo.RouteMonitor.yaml
georgettica 262cfee
on push: make
georgettica 0ecd01d
docs: add discalimer on names
georgettica 373936e
fix(rmo): add namespace
georgettica 9f1e629
on push: make
georgettica fd697a6
Update 100-openshift-console.console.RouteMonitor.yaml
georgettica 4c0e06f
on push: make
georgettica 88258c6
rename file
georgettica d654b28
Update 100-openshift-route-monitor-operator.console.RouteMonitor.yaml
georgettica 3f788cf
on push: make
georgettica 5c7ab5a
Update 100-openshift-route-monitor-operator.console.RouteMonitor.yaml
NautiluX d991386
on push: make
NautiluX 4437a87
Create config.yaml
georgettica 9594eb0
on push: make
georgettica fe0d22a
Create OWNERS
georgettica File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
11 changes: 11 additions & 0 deletions
11
...osd-route-monitor-operator/100-openshift-route-monitor-operator.console.RouteMonitor.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
apiVersion: monitoring.openshift.io/v1alpha1 | ||
kind: RouteMonitor | ||
metadata: | ||
name: console | ||
namespace: openshift-route-monitor-operator | ||
spec: | ||
route: | ||
name: console | ||
namespace: openshift-console | ||
slo: | ||
targetAvailabilityPercent: "99.95" | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
# File Convention | ||
|
||
the convention is: | ||
``` | ||
${NUMBER}-${NS}.${NAME}.${TYPE}.yaml | ||
``` | ||
|
||
## Number | ||
a way to order the resources (if need be), | ||
should be a 3 digit number just in case. | ||
|
||
## Ns | ||
the namespace the resource is created in | ||
|
||
## Name | ||
the name of the resource | ||
|
||
## Type | ||
the type of the resource | ||
|
||
# Caveat | ||
the alert name will be comprised from the RouteMonitor/ClusterUrlMonitor name, so be careful when renaming || Adding |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why now 99.95? According to the SLO doc it should be 99.5? Probably I miss some discussion here...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
turns out this was confused with the API server SLA. We'll change it back to 99.5.