Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(route-monitor-operator): add console monitor [OSD-5499] #736

Merged
Merged
Show file tree
Hide file tree
Changes from 13 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
apiVersion: monitoring.openshift.io/v1alpha1
kind: RouteMonitor
metadata:
name: console
namespace: openshift-route-monitor-operator
spec:
route:
name: console
namespace: openshift-console
slo:
targetAvailabilityPercent: "99.95"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why now 99.95? According to the SLO doc it should be 99.5? Probably I miss some discussion here...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

turns out this was confused with the API server SLA. We'll change it back to 99.5.

22 changes: 22 additions & 0 deletions deploy/osd-route-monitor-operator/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
# File Convention

the convention is:
```
${NUMBER}-${NS}.${NAME}.${TYPE}.yaml
```

## Number
a way to order the resources (if need be),
should be a 3 digit number just in case.

## Ns
the namespace the resource is created in

## Name
the name of the resource

## Type
the type of the resource

# Caveat
the alert name will be comprised from the RouteMonitor/ClusterUrlMonitor name, so be careful when renaming || Adding
25 changes: 25 additions & 0 deletions hack/00-osd-managed-cluster-config-integration.yaml.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -7298,6 +7298,31 @@ objects:
name: cluster
patch: '{"spec":{"defaultRoute":true,"nodeSelector":{"node-role.kubernetes.io/infra":""},"tolerations":[{"effect":"NoSchedule","key":"node-role.kubernetes.io/infra","operator":"Exists"}]}}'
patchType: merge
- apiVersion: hive.openshift.io/v1
kind: SelectorSyncSet
metadata:
labels:
managed.openshift.io/gitHash: ${IMAGE_TAG}
managed.openshift.io/gitRepoName: ${REPO_NAME}
managed.openshift.io/osd: 'true'
name: osd-route-monitor-operator
spec:
clusterDeploymentSelector:
matchLabels:
api.openshift.com/managed: 'true'
resourceApplyMode: Sync
resources:
- apiVersion: monitoring.openshift.io/v1alpha1
kind: RouteMonitor
metadata:
name: console
namespace: openshift-route-monitor-operator
spec:
route:
name: console
namespace: openshift-console
slo:
targetAvailabilityPercent: '99.95'
- apiVersion: hive.openshift.io/v1
kind: SelectorSyncSet
metadata:
Expand Down
25 changes: 25 additions & 0 deletions hack/00-osd-managed-cluster-config-production.yaml.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -7298,6 +7298,31 @@ objects:
name: cluster
patch: '{"spec":{"defaultRoute":true,"nodeSelector":{"node-role.kubernetes.io/infra":""},"tolerations":[{"effect":"NoSchedule","key":"node-role.kubernetes.io/infra","operator":"Exists"}]}}'
patchType: merge
- apiVersion: hive.openshift.io/v1
kind: SelectorSyncSet
metadata:
labels:
managed.openshift.io/gitHash: ${IMAGE_TAG}
managed.openshift.io/gitRepoName: ${REPO_NAME}
managed.openshift.io/osd: 'true'
name: osd-route-monitor-operator
spec:
clusterDeploymentSelector:
matchLabels:
api.openshift.com/managed: 'true'
resourceApplyMode: Sync
resources:
- apiVersion: monitoring.openshift.io/v1alpha1
kind: RouteMonitor
metadata:
name: console
namespace: openshift-route-monitor-operator
spec:
route:
name: console
namespace: openshift-console
slo:
targetAvailabilityPercent: '99.95'
- apiVersion: hive.openshift.io/v1
kind: SelectorSyncSet
metadata:
Expand Down
25 changes: 25 additions & 0 deletions hack/00-osd-managed-cluster-config-stage.yaml.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -7298,6 +7298,31 @@ objects:
name: cluster
patch: '{"spec":{"defaultRoute":true,"nodeSelector":{"node-role.kubernetes.io/infra":""},"tolerations":[{"effect":"NoSchedule","key":"node-role.kubernetes.io/infra","operator":"Exists"}]}}'
patchType: merge
- apiVersion: hive.openshift.io/v1
kind: SelectorSyncSet
metadata:
labels:
managed.openshift.io/gitHash: ${IMAGE_TAG}
managed.openshift.io/gitRepoName: ${REPO_NAME}
managed.openshift.io/osd: 'true'
name: osd-route-monitor-operator
spec:
clusterDeploymentSelector:
matchLabels:
api.openshift.com/managed: 'true'
resourceApplyMode: Sync
resources:
- apiVersion: monitoring.openshift.io/v1alpha1
kind: RouteMonitor
metadata:
name: console
namespace: openshift-route-monitor-operator
spec:
route:
name: console
namespace: openshift-console
slo:
targetAvailabilityPercent: '99.95'
- apiVersion: hive.openshift.io/v1
kind: SelectorSyncSet
metadata:
Expand Down