templates/master/00-master: add 127.0.0.1 to etcd metric proxy SAN. #664
Conversation
etcd-quorum-guard needs the ability to pin to the host etcd instance to check health. Because we are now using the metric chain of trust we need to allow 127.0.0.1 in the SAN the same as etcd server currently does to simplify these TLS connections. Signed-off-by: Sam Batschelet <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: hexfusion If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
size/S
|
/cc @RobertKrawitz |
|
@hexfusion I thought 613 was closed? |
see that don't pay attention for 5 mins :). |
|
@kikisdeliveryservice actually we still want quorum guard standalone to use metric certs so I would like to keep this open if possible. |
|
@hexfusion @kikisdeliveryservice this could also be used to allow the standalone etcd-quorum-guard to use the metrics cert. |
|
/retest |
|
/test e2e-aws |
|
@hexfusion: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
I think there are some wider spread aws issues right now, so retesting might not help. |
|
@hexfusion is there any guarantee that the proxy won't cache health status (which would defeat the whole purpose of the quorum guard)? |
|
@RobertKrawitz the proxy has no caching mechanism it has a handler that makes an HTTP request. On the curl side we could pass |
|
We are not going to use metric certs for this use-case anymore closing |
etcd-quorum-guard needs the ability to pin to the host etcd instance to check health. Because we are now using the metric chain of trust we need to allow 127.0.0.1 in the SAN the same as etcd server currently does to simplify these TLS connections.
Assists #613