daemon: Support unpivoted images #1155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/S
openshift-ci-robot
added
the
approved
|
Tested locally in a libvirt build with custom local RHCOS via where the bootimage isn't pivoted. Will let CI cover the current path. |
cgwalters
force-pushed
the
handle-not-pivot
branch
from
d286884 to
892e7ed
Compare
openshift-ci-robot
added
size/M
|
/retest |
runcom
reviewed
Oct 6, 2019
|
/approve |
Today the RHCOS bootimages come "prepivoted"; they have a custom origin set to the `machine-os-content` that matches. The idea here is to avoid an extra reboot. In practice we're always going to be updating and rebooting today, because we don't have a mechanism to update bootimages: openshift/os#381 I plan to change the RHCOS build system to stop "prepivoting"; the oscontainer will be pushed *after* the bootimages. This breaks a complicated dependency and ensures that the RHCOS "source of truth" is the cosa storage. Also, this allows one to use the MCD when e.g. booting Fedora CoreOS. Closes: openshift#981
cgwalters
force-pushed
the
handle-not-pivot
branch
from
892e7ed to
c63310a
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, kikisdeliveryservice, runcom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today the RHCOS bootimages come "prepivoted"; they have a custom
origin set to the
machine-os-contentthat matches. The ideahere is to avoid an extra reboot.
In practice we're always going to be updating and rebooting today,
because we don't have a mechanism to update bootimages:
openshift/os#381
I plan to change the RHCOS build system to stop "prepivoting"; the
oscontainer will be pushed after the bootimages. This breaks
a complicated dependency and ensures that the RHCOS "source of truth"
is the cosa storage.
Also, this allows one to use the MCD when e.g. booting Fedora CoreOS.
Closes: #981