Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent OSImageURL from being set by users #465

Closed
runcom opened this issue Feb 20, 2019 · 0 comments · Fixed by #475
Closed

Prevent OSImageURL from being set by users #465

runcom opened this issue Feb 20, 2019 · 0 comments · Fixed by #475

Comments

@runcom
Copy link
Member

runcom commented Feb 20, 2019 •
edited
Loading

I'd love a way to prevent people from creating machineconfigs that set osimageurl (and/or edit the current ones?). Ideally, I can see the CVO driving that w/o user input at all. This will reduce the chance for users to do something bad (in my view, if it's not wrong).
We could detect if a machineconfig has an osimageurl and just override it with what we have in the controllerconfig resulting in a no-op for users.
@runcom runcom mentioned this issue Feb 21, 2019
Merged
cgwalters added a commit to cgwalters/machine-config-operator that referenced this issue Feb 21, 2019
@cgwalters
machineconfig: Drop osimageurl from oc get machineconfigs
858f286 
We really want this driven by the CVO; people should look at
`oc get clusterversion`.

See also:

 - openshift/os#377
 - openshift#465
@runcom runcom mentioned this issue Feb 22, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bug 1691660: pkg/controller: always use the OSImageURL from the CVO runcom/machine-config-operator
1 participant
@runcom