Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CFE-683 : Update openshift/api package to latest version #56

Merged
merged 1 commit into from
Aug 7, 2023
Merged

CFE-683 : Update openshift/api package to latest version #56

merged 1 commit into from
Aug 7, 2023

Conversation

bharath-b-rh
Copy link
Contributor

PR is for updating the openshift/api package to the latest version which contains the API changes for supporting GCP labels & tags made in openshift/api#1445

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 25, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 25, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@bharath-b-rh
Copy link
Contributor Author

/hold openshift/api#1445

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 25, 2023
@jianli-wei
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Aug 4, 2023
@bharath-b-rh
Copy link
Contributor Author

/remove-hold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 5, 2023
@bharath-b-rh bharath-b-rh marked this pull request as ready for review August 5, 2023 15:14
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 5, 2023
@openshift-ci openshift-ci bot requested review from elmiko and odvarkadaniel August 5, 2023 15:15
@bharath-b-rh
Copy link
Contributor Author

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 6, 2023

@bharath-b-rh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bharath-b-rh
Copy link
Contributor Author

/assign @JoelSpeed

@JoelSpeed
Copy link
Contributor

Updating the API is fine, but what about the actual implementation? We are waiting on support in cluster-api-provider-gcp as well right?

You'll need to update machine-api-operator for the webhooks as well btw

@bharath-b-rh
Copy link
Contributor Author

Updating the API is fine, but what about the actual implementation? We are waiting on support in cluster-api-provider-gcp as well right?

You'll need to update machine-api-operator for the webhooks as well btw

cluster-api-provider-gcp already has support for adding labels. I have created an issue for supporting tags. But for TP tags for worker compute instances will be a limitation.

@JoelSpeed
Copy link
Contributor

What does this PR currently achieve? Does this controller already support labels as well? Does it need to be adding the labels from the infrastructure object now as well?

@bharath-b-rh
Copy link
Contributor Author

With this PR we will update the version of openshift/api which support resourceLabels configuration in Infrastructure API. Controller already has the functionality for adding those labels in Machine and MachineSet to Compute Instance, #53 requires the pkg update for merging user-defined labels in Infrastructure with the ProviderSpec labels.

@JoelSpeed
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 7, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2023
@openshift-merge-robot openshift-merge-robot merged commit e8d655d into openshift:main Aug 7, 2023
@bharath-b-rh bharath-b-rh deleted the cfe-683-api branch August 7, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elmiko elmiko Awaiting requested review from elmiko

@odvarkadaniel odvarkadaniel Awaiting requested review from odvarkadaniel

Assignees

@JoelSpeed JoelSpeed

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bharath-b-rh @jianli-wei @JoelSpeed @openshift-merge-robot