Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1878880: Fix confusing log messages about deleting Node #681

Merged
merged 1 commit into from
Sep 14, 2020
Merged

Bug 1878880: Fix confusing log messages about deleting Node #681

merged 1 commit into from
Sep 14, 2020

Conversation

zaneb
Copy link
Member

@zaneb zaneb commented Aug 19, 2020

These two log messages were inconsistent with the format of all the others. In particular it is very confusing to see the message deleting node <machine name> for machine.

@zaneb
Fix confusing log messages about deleting Node
c16e0d3 
These two log messages were inconsistent with the format of all the
others. In particular it is very confusing to see the message "deleting
node <machine name> for machine".
michaelgugino
michaelgugino approved these changes Aug 19, 2020
View reviewed changes
Copy link
Contributor

@michaelgugino michaelgugino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2020
@zaneb
Copy link
Member Author

zaneb commented Aug 27, 2020

/retest

@enxebre
Copy link
Member

enxebre commented Aug 31, 2020

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

19 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@zaneb
Copy link
Member Author

zaneb commented Sep 14, 2020

/retitle Bug 1878880: Fix confusing log messages about deleting Node

@openshift-ci-robot openshift-ci-robot changed the title Fix confusing log messages about deleting Node Bug 1878880: Fix confusing log messages about deleting Node Sep 14, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. label Sep 14, 2020
@openshift-ci-robot
Copy link
Contributor

@zaneb: This pull request references Bugzilla bug 1878880, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1878880: Fix confusing log messages about deleting Node

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 14, 2020
@openshift-merge-robot openshift-merge-robot merged commit 2b0f59d into openshift:master Sep 14, 2020
@openshift-ci-robot
Copy link
Contributor

@zaneb: All pull requests linked via external trackers have merged:

Bugzilla bug 1878880 has been moved to the MODIFIED state.

In response to this:

Bug 1878880: Fix confusing log messages about deleting Node

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Sep 22, 2020
Merged
Merged
elmiko added a commit to elmiko/cluster-api-provider-baremetal that referenced this pull request Sep 22, 2020
@elmiko
Bug 1878880: re-vendor machine-api-operator at e0db6b65
96f74b4 
This change is being proposed to pick up the recent log message changes
as proposed in
openshift/machine-api-operator#681
@elmiko elmiko mentioned this pull request Sep 22, 2020
Merged
elmiko added a commit to elmiko/cluster-api-provider-gcp that referenced this pull request Sep 22, 2020
@elmiko
Bug 1878880: re-vendor machine-api-operator at e0db6b65
ee710d4 
This change is being proposed to pick up the recent log message changes
as proposed in
openshift/machine-api-operator#681
elmiko added a commit to elmiko/cluster-api-provider-openstack that referenced this pull request Sep 22, 2020
@elmiko
Bug 1878880: re-vendor machine-api-operator at e0db6b65
6cb8f44 
This change is being proposed to pick up the recent log message changes
as proposed in
openshift/machine-api-operator#681
This was referenced Sep 22, 2020
Closed
Merged
openshift-merge-robot pushed a commit to openshift/cluster-api-provider-azure that referenced this pull request Sep 23, 2020
@elmiko @openshift-merge-robot
UPSTREAM: <carry>: openshift: Bug 1878880: re-vendor machine-api-oper…
cd15c1c 
…ator at e0db6b65

This change is being proposed to pick up the recent log message changes
as proposed in
openshift/machine-api-operator#681
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelgugino michaelgugino michaelgugino approved these changes

@elmiko elmiko Awaiting requested review from elmiko

Assignees

@michaelgugino michaelgugino

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zaneb @enxebre @openshift-ci-robot @openshift-bot @michaelgugino @openshift-merge-robot