Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add images required for bringing up a baremetal deployment. #367

Merged
merged 1 commit into from
Aug 1, 2019
Merged

Add images required for bringing up a baremetal deployment. #367

merged 1 commit into from
Aug 1, 2019

Conversation

sadasu
Copy link
Contributor

@sadasu sadasu commented Jul 30, 2019

Adding images required for a successful Baremetal pod deployment. This is a pre-requisite for #302.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 30, 2019
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 30, 2019
@sadasu sadasu force-pushed the metal3-images branch 2 times, most recently from e284726 to 65d8c22 Compare July 30, 2019 15:02
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 30, 2019
russellb
russellb reviewed Jul 30, 2019
View reviewed changes
install/image-references Outdated
- name: metal3-ironic
from:
kind: DockerImage
name: docker://brew-pulp-docker01.web.prod.ext.phx2.redhat.com:8888/openshift/ose-ironic:v4.2.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should all match the pattern used by the others, like quay.io/openshift/origin-ironic:v4.2.0

If it's not there, maybe we need some mirroring configuration added to openshift/release first

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and remember that these are mostly just placeholders and get replaced with something else when the release image gets built

@sadasu sadasu force-pushed the metal3-images branch 5 times, most recently from 7933b18 to 2554267 Compare July 30, 2019 18:17
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 30, 2019
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 30, 2019
@russellb
Copy link
Member

/test e2e-aws

It makes sense that this is passing now with just baremetal-operator and ironic-ipa-downloader. Those are the ones I'd expect to be present after reviewing the status of adding all of these to openshift/release.

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 1, 2019
@sadasu sadasu force-pushed the metal3-images branch 2 times, most recently from 3cb89a5 to 85ca754 Compare August 1, 2019 14:25
russellb
russellb reviewed Aug 1, 2019
View reviewed changes
install/image-references
kind: DockerImage
name: quay.io/openshift/origin-baremetal-operator:v4.2.0
- name: ironic-inspector
from:

This comment was marked as resolved.

Sign in to view

@sadasu sadasu force-pushed the metal3-images branch 3 times, most recently from 6ea873c to db170f8 Compare August 1, 2019 15:02
@russellb
Copy link
Member

russellb commented Aug 1, 2019

/test images

@russellb
Copy link
Member

russellb commented Aug 1, 2019

/test images

russellb
russellb reviewed Aug 1, 2019
View reviewed changes
install/image-references Outdated Show resolved Hide resolved
@sadasu sadasu changed the title WIP: Add images required for bringing up a baremetal deployment. Add images required for bringing up a baremetal deployment. Aug 1, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 1, 2019
michaelgugino
michaelgugino approved these changes Aug 1, 2019
View reviewed changes
Copy link
Contributor

@michaelgugino michaelgugino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 1, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michaelgugino

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2019
@openshift-merge-robot openshift-merge-robot merged commit 1b52288 into openshift:master Aug 1, 2019
@sadasu sadasu mentioned this pull request Aug 1, 2019
Merged
@enxebre
Copy link
Member

enxebre commented Aug 2, 2019 •
edited
Loading

@sadasu @russellb is this already under ART build process. If not this will break CI payload build

@russellb
Copy link
Member

russellb commented Aug 2, 2019

@sadasu @russellb is this already under ART build process. If not this will break CI

I thought it was, will follow up

@sadasu
Copy link
Contributor Author

sadasu commented Aug 2, 2019

https://jira.coreos.com/browse/ART-754 - Ironic Image
https://jira.coreos.com/browse/ART-755 - Ironic Inspector image
https://jira.coreos.com/browse/ART-756 - Ironic Ipa downloader image
https://jira.coreos.com/browse/ART-757 - ironic-rhcos-downloader image
https://jira.coreos.com/browse/ART-758 - Ironic Static-ip-manager image

@enxebre I think these are what you are looking for.

@russellb
Copy link
Member

russellb commented Aug 2, 2019

There was an issue that caused ART builds to break.

https://bugzilla.redhat.com/show_bug.cgi?id=1737086

PR for the fix: openshift/ironic-image#10

@sadasu sadasu deleted the metal3-images branch February 4, 2020 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@russellb russellb russellb left review comments

@michaelgugino michaelgugino michaelgugino approved these changes

@enxebre enxebre Awaiting requested review from enxebre

@spangenberg spangenberg Awaiting requested review from spangenberg

Assignees

@michaelgugino michaelgugino

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sadasu @russellb @openshift-ci-robot @enxebre @michaelgugino @openshift-merge-robot