Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect InstallConfig.Platform.AWS.UserTags #97

Closed
wking opened this issue Oct 15, 2018 · 1 comment
Closed

Respect InstallConfig.Platform.AWS.UserTags #97

wking opened this issue Oct 15, 2018 · 1 comment

Comments

@wking
Copy link
Member

wking commented Oct 15, 2018

This operator currently sets tectonicClusterID, but seems to ignore UserTags, which we use for things like expirationDate (openshift/release#1761). openshift/installer#465 is in flight with a generic helper that may make it easier to get the appropriate tags, but I'm not clear on how well that will plug in here. I'm also not sure how this plays with worker machine-sets possibly moving into the installer (CC @abhinavdahiya).

Thoughts?
@enxebre
Copy link
Member

enxebre commented Oct 29, 2018

Closing this as machines definition lives on the installer now
For reference:
openshift/installer#468
https://github.com/openshift/installer/tree/master/pkg/asset/machines

@enxebre enxebre closed this as completed Oct 29, 2018
ingvagabund pushed a commit to ingvagabund/machine-api-operator that referenced this issue Jul 11, 2019
@openshift-merge-robot
Merge pull request openshift#97 from spangenberg/availability-zone
947111b 
Incorporate availability zone into placement decision
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wking @enxebre