Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OLS-1225: fix port number for calling the service from Gradio #1946

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

OLS-1225: fix port number for calling the service from Gradio #1946

wants to merge 2 commits into from
+174 −1

Conversation

tisnik
Copy link
Contributor

@tisnik tisnik commented Nov 24, 2024 •
edited by openshift-ci bot
Loading

Description

OLS-1225: fix port number for calling the service from Gradio

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change

Related Tickets & Documents

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 24, 2024 •
edited by openshift-ci bot
Loading

@tisnik: This pull request references OLS-1225 which is a valid jira issue.

In response to this:

Description

OLS-1225: fix port number for calling the service from Gradio

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change

Related Tickets & Documents

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 24, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 24, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.79%. Comparing base (b3b5488) to head (39de190).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
ols/app/main.py 66.66% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1946       +/-   ##
===========================================
+ Coverage   73.05%   96.79%   +23.74%     
===========================================
  Files          67       69        +2     
  Lines        2872     2904       +32     
===========================================
+ Hits         2098     2811      +713     
+ Misses        774       93      -681
Files with missing lines Coverage Δ
ols/app/main.py 92.68% <66.66%> (-0.76%) ⬇️

... and 36 files with indirect coverage changes

---- 🚨 Try these New Features:

@tisnik
Copy link
Contributor Author

tisnik commented Nov 25, 2024

/approve
/override "Red Hat Konflux / ols-enterprise-contract / lightspeed-service"
/override "ci/prow/4.15-e2e-ols-cluster"
/override "ci/prow/4.16-e2e-ols-cluster"
/override "ci/prow/4.17-e2e-ols-cluster"

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tisnik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 25, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 25, 2024

@tisnik: Overrode contexts on behalf of tisnik: Red Hat Konflux / ols-enterprise-contract / lightspeed-service, ci/prow/4.15-e2e-ols-cluster, ci/prow/4.16-e2e-ols-cluster, ci/prow/4.17-e2e-ols-cluster

In response to this:

/approve
/override "Red Hat Konflux / ols-enterprise-contract / lightspeed-service"
/override "ci/prow/4.15-e2e-ols-cluster"
/override "ci/prow/4.16-e2e-ols-cluster"
/override "ci/prow/4.17-e2e-ols-cluster"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@JoaoFula
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 25, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b3d46df and 2 for PR HEAD 39de190 in total

@tisnik
Copy link
Contributor Author

tisnik commented Nov 25, 2024

/retest

@tisnik
Copy link
Contributor Author

tisnik commented Nov 25, 2024

/test unit
/test integration
/test verify

@tisnik
Copy link
Contributor Author

tisnik commented Nov 25, 2024

/override "ci/prow/unit"
/override "ci/prow/verify"

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 25, 2024

@tisnik: Overrode contexts on behalf of tisnik: ci/prow/unit, ci/prow/verify

In response to this:

/override "ci/prow/unit"
/override "ci/prow/verify"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD a6cebc0 and 1 for PR HEAD 39de190 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD a6cebc0 and 2 for PR HEAD 39de190 in total

@tisnik
Copy link
Contributor Author

tisnik commented Nov 25, 2024

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 3f5ae5a and 1 for PR HEAD 39de190 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 010acff and 0 for PR HEAD 39de190 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 010acff and 2 for PR HEAD 39de190 in total

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 25, 2024

@tisnik: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.17-e2e-ols-cluster 39de190 link true /test 4.17-e2e-ols-cluster
ci/prow/4.16-e2e-ols-cluster 39de190 link true /test 4.16-e2e-ols-cluster
ci/prow/4.15-e2e-ols-cluster 39de190 link true /test 4.15-e2e-ols-cluster

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD ef41bea and 1 for PR HEAD 39de190 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD a6c3717 and 0 for PR HEAD 39de190 in total

@tisnik
Copy link
Contributor Author

tisnik commented Nov 25, 2024

/test 4.15-e2e-ols-cluster
/test 4.16-e2e-ols-cluster

@tisnik
Copy link
Contributor Author

tisnik commented Nov 25, 2024

/test 4.17-e2e-ols-cluster

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuawilson joshuawilson Awaiting requested review from joshuawilson

@xrajesh xrajesh Awaiting requested review from xrajesh

Assignees

@JoaoFula JoaoFula

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tisnik @openshift-ci-robot @codecov-commenter @JoaoFula