[wip]OTA-1010: pull GetImplicitlyEnabledCapabilities from the cvo repo #1908
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@hongkailiu: This pull request references OTA-1010 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: hongkailiu The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
hongkailiu
force-pushed
the
OTA-1010
branch
5 times, most recently
from
f187e0e to
8c7531f
Compare
hongkailiu
force-pushed
the
OTA-1010
branch
2 times, most recently
from
9cd9e07 to
9cbf3c7
Compare
hongkailiu
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/cc @wking @petr-muller |
There was a problem hiding this comment.
Code is just a lift from CVO so maybe that's enough, but it actually looks quite legacy and I would be in favor of some significant refactors if this was new code. And because we're including this in a library, I believe it should meet the bar for new code.
The capabilities are basically treated as sets but we do not use apimachinery Set type and include a lot of code that would not be needed if we used it.
pkg/capability/capability.go
Outdated
| func GetImplicitlyEnabledCapabilities(enabledCapabilities []configv1.ClusterVersionCapability, | ||
| capabilities []configv1.ClusterVersionCapability, | ||
| clusterCapabilities ClusterCapabilities) []configv1.ClusterVersionCapability { |
There was a problem hiding this comment.
TBH the signature and the godoc does not help too much in understanding what is the purpose of the method and what (high-level, semantic) operation ti performs. You give it some capabilities, and it filters some out. It is supposed to return implicitly enabled capabilities, but at the same time, it filters the content of clusterCapabilities.ImplicitlyEnabledCapabilities out? That's confusing. Also, if I am a caller, how is enabledCapabilities different from clusterCapabilities.EnabledCapabilities?
Also, they are all capabilities, so calling the variables as such does not help much. Could we call them enabled and input or something that carries more semantics?
|
Also I think the commit and the PR needs descriptions to explain why the code is pulled from CVO and where do we intend to use it. |
hongkailiu
changed the title
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
I was thinking about "set" too but did not go. |
|
|
||
| // GetImplicitlyEnabledCapabilities returns the capabilities from | ||
| // a set of capabilities that are not (even implicitly) enabled in ClusterCapabilities: | ||
| func GetImplicitlyEnabledCapabilities( |
There was a problem hiding this comment.
This one seems too simple to be exported.
Let me think.
|
@hongkailiu: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
No description provided.