Bug 1902710: UPSTREAM: 89726: Backward support for old KVM driver

[mandre]

With newer versions of OpenStack/libvirt, the path of the attached block storage volume now contains the full volume ID when using virtio-scsi.

The problem is described in the upstream OpenStack cloud provider repository on github [1] and k8s/community [2] and was fixed already for the external cloud provider [3]. However, the fix was never merged for the in-tree cloud provider [4].

Without this change, the Cinder PVC times out attaching the storage to the node when using virtio-scsi and the in-tree cinder provisioned on OSP16.

Kubelet logs show:
Nov 30 12:38:35 mandre-psi-pub-stlh7-worker-0-b4xhh hyperkube[1868]: W1130 12:38:35.640309 1868 openstack_volumes.go:576] Failed to find device for the volumeID: "bcc21b3e-23fa-4464-844c-62506e298744"
Nov 30 12:38:35 mandre-psi-pub-stlh7-worker-0-b4xhh hyperkube[1868]: E1130 12:38:35.640319 1868 attacher.go:249] Error: could not find attached Cinder disk "bcc21b3e-23fa-4464-844c-62506e298744" (path: ""):

[1] kubernetes/cloud-provider-openstack#852
[2] kubernetes/community#4797
[2] kubernetes/cloud-provider-openstack#853
[3] kubernetes#89726

[openshift-ci-robot]

@mandre: This pull request references Bugzilla bug 1902710, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.7.0) matches configured target release for branch (4.7.0)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1902710: UPSTREAM: 89726: Backward support for old KVM driver

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mandre
To complete the pull request process, please assign smarterclayton after the PR has been reviewed.
You can assign the PR to them by writing /assign @smarterclayton in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• staging/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mandre]

/retest

[mandre]

/retest

[openshift-merge-robot]

@mandre: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-agnostic-cmd	80235d3	link	/test e2e-agnostic-cmd
ci/prow/e2e-gcp	80235d3	link	/test e2e-gcp
ci/prow/k8s-e2e-gcp	80235d3	link	/test k8s-e2e-gcp

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[sttts]

/hold

this got rotten upstream and closed. Please reopen and get it merged.

[mandre]

Thanks @sttts, I just noticed @jsafrane had a similar change at kubernetes#96673.
This is the one we'll want to merge.
/close

[openshift-ci-robot]

@mandre: Closed this PR.

In response to this:

Thanks @sttts, I just noticed @jsafrane had a similar change at kubernetes#96673.
This is the one we'll want to merge.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@mandre: This pull request references Bugzilla bug 1902710. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

In response to this:

Bug 1902710: UPSTREAM: 89726: Backward support for old KVM driver

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.