Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.10] Bug 2017276: UPSTREAM: 105934: Don't guess SELinux support on error #1052

Merged
merged 1 commit into from
Nov 19, 2021
Merged

[4.10] Bug 2017276: UPSTREAM: 105934: Don't guess SELinux support on error #1052

merged 1 commit into from
Nov 19, 2021

Conversation

jsafrane
Copy link

When GetSELinuxSupport() fails, don't assume a mounted filesystem does not support SELinux at all. Try again instead in the next SetUp retry.

cc @openshift/storage

@jsafrane
UPSTREAM: 105934: Don't guess SELinux support on error
475b7e8 
When GetSELinuxSupport() fails, don't assume a mounted filesystem does not support SELinux at all. Try again instead in the next SetUp retry.
@openshift-ci-robot openshift-ci-robot added the backports/validated-commits Indicates that all commits come to merged upstream PRs. label Nov 15, 2021
@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Nov 15, 2021
@openshift-ci
Copy link

openshift-ci bot commented Nov 15, 2021

@jsafrane: This pull request references Bugzilla bug 2017276, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @Phaow

In response to this:

Bug 2017276: UPSTREAM: 105934: Don't guess SELinux support on error

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from Phaow November 15, 2021 14:40
@openshift-ci-robot
Copy link

@jsafrane: the contents of this pull request could be automatically validated.

The following commits are valid:

@openshift-ci openshift-ci bot requested review from deads2k and mfojtik November 15, 2021 14:47
@jsafrane jsafrane changed the title Bug 2017276: UPSTREAM: 105934: Don't guess SELinux support on error [4.10] Bug 2017276: UPSTREAM: 105934: Don't guess SELinux support on error Nov 15, 2021
@dobsonj
Copy link
Member

dobsonj commented Nov 15, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2021
@Phaow
Copy link

Phaow commented Nov 17, 2021

/lgtm
/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Nov 17, 2021
Phaow
Phaow reviewed Nov 17, 2021
View reviewed changes
Copy link

@Phaow Phaow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsafrane
Copy link
Author

/label backport-risk-assessed

@openshift-ci
Copy link

openshift-ci bot commented Nov 19, 2021

@jsafrane: Can not set label backport-risk-assessed: Must be member in one of these teams: []

In response to this:

/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jsafrane
Copy link
Author

/label backport-risk-assessed

@openshift-ci
Copy link

openshift-ci bot commented Nov 19, 2021

@jsafrane: Can not set label backport-risk-assessed: Must be member in one of these teams: []

In response to this:

/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jsafrane
Copy link
Author

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Nov 19, 2021
@jsafrane
Copy link
Author

/retest-required

soltysh
soltysh approved these changes Nov 19, 2021
View reviewed changes
Copy link

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link

openshift-ci bot commented Nov 19, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dobsonj, jsafrane, Phaow, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 19, 2021
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link

openshift-ci bot commented Nov 19, 2021 •
edited
Loading

@jsafrane: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agnostic-cmd 475b7e8 link false /test e2e-agnostic-cmd
ci/prow/e2e-aws-cgroupsv2 475b7e8 link false /test e2e-aws-cgroupsv2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 35a59a5 into openshift:master Nov 19, 2021
@openshift-ci
Copy link

openshift-ci bot commented Nov 19, 2021

@jsafrane: All pull requests linked via external trackers have merged:

Bugzilla bug 2017276 has been moved to the MODIFIED state.

In response to this:

[4.10] Bug 2017276: UPSTREAM: 105934: Don't guess SELinux support on error

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Phaow Phaow Phaow left review comments

@soltysh soltysh soltysh approved these changes

@deads2k deads2k Awaiting requested review from deads2k

@mfojtik mfojtik Awaiting requested review from mfojtik

Assignees

@dobsonj dobsonj

@Phaow Phaow

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. backports/validated-commits Indicates that all commits come to merged upstream PRs. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jsafrane @openshift-ci-robot @dobsonj @Phaow @openshift-bot @soltysh @openshift-merge-robot