Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-25852: UPSTREAM: <carry>: 🐛(metrics) Initialize metrics for autoscaler errors, scale events, and pod evictions #332

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

theobarberbany
Copy link

@theobarberbany theobarberbany commented Dec 13, 2024

Carry kubernetes#7449

  • Set initial count to zero for various autoscaler error types (e.g., CloudProviderError, ApiCallError)
  • Define failed scale-up reasons and initialize metrics (e.g., CloudProviderError, APIError)
  • Initialize pod eviction result counters for success and failure cases
  • Initialize skipped scale events for CPU and memory resource limits in both scale-up and scale-down directions

…s, scale events, and pod evictions

- Set initial count to zero for various autoscaler error types (e.g., CloudProviderError, ApiCallError)
- Define failed scale-up reasons and initialize metrics (e.g., CloudProviderError, APIError)
- Initialize pod eviction result counters for success and failure cases
- Initialize skipped scale events for CPU and memory resource limits in both scale-up and scale-down directions

Signed-off-by: Thiha Min Thant <[email protected]>
@openshift-ci openshift-ci bot requested review from elmiko and enxebre December 13, 2024 12:32
@theobarberbany theobarberbany changed the title UPSTREAM: <carry>: 🐛(metrics) Initialize metrics for autoscaler errors, scale events, and pod evictions OCPBUGS-25852: UPSTREAM: <carry>: 🐛(metrics) Initialize metrics for autoscaler errors, scale events, and pod evictions Dec 13, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 13, 2024
@openshift-ci-robot
Copy link

@theobarberbany: This pull request references Jira Issue OCPBUGS-25852, which is invalid:

  • expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Carry kubernetes#7449

  • Set initial count to zero for various autoscaler error types (e.g., CloudProviderError, ApiCallError)
  • Define failed scale-up reasons and initialize metrics (e.g., CloudProviderError, APIError)
  • Initialize pod eviction result counters for success and failure cases
  • Initialize skipped scale events for CPU and memory resource limits in both scale-up and scale-down directions

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@theobarberbany
Copy link
Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 13, 2024
@openshift-ci-robot
Copy link

@theobarberbany: This pull request references Jira Issue OCPBUGS-25852, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @miyadav

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from miyadav December 13, 2024 12:33
@JoelSpeed
Copy link

/approve
/lgtm

@theobarberbany Which release do we need to backport this to?

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 13, 2024
Copy link

openshift-ci bot commented Dec 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 13, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 995ce9f into openshift:master Dec 13, 2024
12 of 16 checks passed
@openshift-ci-robot
Copy link

@theobarberbany: Jira Issue OCPBUGS-25852: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-25852 has been moved to the MODIFIED state.

In response to this:

Carry kubernetes#7449

  • Set initial count to zero for various autoscaler error types (e.g., CloudProviderError, ApiCallError)
  • Define failed scale-up reasons and initialize metrics (e.g., CloudProviderError, APIError)
  • Initialize pod eviction result counters for success and failure cases
  • Initialize skipped scale events for CPU and memory resource limits in both scale-up and scale-down directions

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

openshift-ci bot commented Dec 13, 2024

@theobarberbany: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 91e89f9 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-periodic-pre 91e89f9 link false /test e2e-aws-periodic-pre

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@theobarberbany
Copy link
Author

theobarberbany commented Dec 13, 2024

@JoelSpeed the bug specifies 4.12,13,14,15 - I would assume 4.16,17,18 as well though...

@theobarberbany
Copy link
Author

/cherry-pick release-4.18

@JoelSpeed
Copy link

Let's start by going back to 4.16 and leave it there for now, unless there's a particular high need I don't think this warrants go further back

@openshift-cherrypick-robot

@theobarberbany: new pull request created: #333

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: vertical-pod-autoscaler
This PR has been included in build ose-vertical-pod-autoscaler-container-v4.19.0-202412131606.p0.g995ce9f.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: atomic-openshift-cluster-autoscaler
This PR has been included in build atomic-openshift-cluster-autoscaler-container-v4.19.0-202412131606.p0.g995ce9f.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants