Skip to content

Commit

Permalink
UPSTREAM: <carry>: remove deprecated go test command
Browse files Browse the repository at this point in the history
this change removes the `go test -i ...` command from the
hack/test-go.sh file. this option is deprecated in the go command and
attempts to install dependencies of the test. when this is enabled with
the build tags we are using, it appears to make the test builds unstable
in CI.
  • Loading branch information
elmiko committed Sep 19, 2022
1 parent 1cd8059 commit 0b411a6
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions hack/test-go.sh
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,6 @@ if [[ -n "${junit_report}" ]]; then
# we don't care if the `go test` fails in this pipe, as we want to generate the report and summarize the output anyway
set +o pipefail

go test -i ${gotest_flags} ${test_packages}
go test ${gotest_flags} ${test_packages} 2>"${test_error_file}" | tee "${JUNIT_REPORT_OUTPUT}"

test_return_code="${PIPESTATUS[0]}"
Expand All @@ -162,7 +161,6 @@ $( cat "${test_error_file}") "

elif [[ -n "${coverage_output_dir}" ]]; then
# we need to generate coverage reports
go test -i ${gotest_flags} ${test_packages}
for test_package in ${test_packages}; do
mkdir -p "${coverage_output_dir}/${test_package}"
local_gotest_flags="${gotest_flags} -coverprofile=${coverage_output_dir}/${test_package}/profile.out"
Expand All @@ -187,6 +185,5 @@ elif [[ -n "${dlv_debug}" ]]; then
dlv test ${test_packages}
else
# we need to generate neither jUnit XML nor coverage reports
go test -i ${gotest_flags} ${test_packages}
go test ${gotest_flags} ${test_packages}
fi

0 comments on commit 0b411a6

Please sign in to comment.