Skip to content
This repository has been archived by the owner on Dec 1, 2022. It is now read-only.

[RELEASE-1.6] Reset drainer to avoid deadlock when liveness probe fails #1311

Closed
wants to merge 1 commit into from

Conversation

nak3
Copy link

@nak3 nak3 commented Nov 10, 2022

This is a backport of #1252.

/cc @skonto

@openshift-ci openshift-ci bot requested a review from skonto November 10, 2022 12:41
@openshift-ci openshift-ci bot added the area/test-and-release Issues or PRs related to test and release label Nov 10, 2022
@openshift-ci
Copy link

openshift-ci bot commented Nov 10, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nak3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 10, 2022
@nak3
Copy link
Author

nak3 commented Nov 10, 2022

1.7 or later has this.

@skonto
Copy link

skonto commented Nov 11, 2022

/test 48-e2e-aws-ocp-48

@openshift-ci
Copy link

openshift-ci bot commented Nov 11, 2022

@nak3: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nak3
Copy link
Author

nak3 commented Nov 14, 2022

This wasn't merged last week...

@mgencur
Copy link

mgencur commented Nov 14, 2022

Please send this PR against https://github.com/openshift-knative/serving . The current CI setup was disabled for openshift/knative-serving.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Issues or PRs related to test and release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants