This repository has been archived by the owner on Dec 1, 2022. It is now read-only.
[RELEASE-1.4] Inject images, generate manifests #1169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skonto
changed the title
openshift-ci
bot
added
the
approved
|
/retest |
Seems an image issue.. Image was updated 5h ago. Some jobs finished before the change. In jobs we use amd64. |
|
/lgtm |
|
/lgtm cancel The CI keeps running. We should run it after openshift-knative/serverless-operator#1644 was solved. |
|
/retest |
|
@skonto: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nak3, skonto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-robot
pushed a commit
that referenced
this pull request
Jul 27, 2022
* [RELEASE-1.4] Inject images, generate manifests (#1169) * inject images, generate manifests (#1150) * Revert temoprary branch for image injection (#1159) Co-authored-by: Kenjiro Nakayama <[email protected]> * fixes for 1.5 * Kourier image injection (#1173) * Revert temoprary branch for image injection (#1186) Co-authored-by: Kenjiro Nakayama <[email protected]>
openshift-merge-robot
pushed a commit
that referenced
this pull request
Aug 1, 2022
* [RELEASE-1.4] Inject images, generate manifests (#1169) * inject images, generate manifests (#1150) * Revert temoprary branch for image injection (#1159) Co-authored-by: Kenjiro Nakayama <[email protected]> * fixes for 1.6 * Kourier image injection (#1173) * Revert temoprary branch for image injection (#1186) Co-authored-by: Kenjiro Nakayama <[email protected]>
openshift-merge-robot
pushed a commit
that referenced
this pull request
Aug 2, 2022
* [RELEASE-1.4] Inject images, generate manifests (#1169) * inject images, generate manifests (#1150) * Revert temoprary branch for image injection (#1159) Co-authored-by: Kenjiro Nakayama <[email protected]> * fixes for main * Kourier image injection (#1173) * Revert temoprary branch for image injection (#1186) * add pdb fix * Revert "add pdb fix" This reverts commit 1790632. Co-authored-by: Kenjiro Nakayama <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick with modifications of #1150.
We need this so that
make generated-filesat the S-O works as expected for 1.25 (coming next).Also uses image injection. Will do one for 1.5 too.
Blocks openshift-knative/serverless-operator#1642 as we are moving to 1.25 after the cut.