Skip to content
This repository has been archived by the owner on Dec 1, 2022. It is now read-only.

[0.26] Embed Kn Plugin Event at ffdcc78 #920

Conversation

@openshift-ci openshift-ci bot requested review from dsimansk and matzew December 23, 2021 14:34
@cardil
Copy link
Author

cardil commented Dec 23, 2021

/cc @rhuss
/cc @mgencur

@openshift-ci openshift-ci bot requested review from mgencur and rhuss December 23, 2021 14:36
@cardil
Copy link
Author

cardil commented Dec 23, 2021

/retest

@openshift-ci
Copy link

openshift-ci bot commented Dec 23, 2021

@cardil: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rhuss
Copy link

rhuss commented Jan 3, 2022

@dsimansk this PR looks good to me, but would like to have a second opinion

@dsimansk
Copy link

dsimansk commented Jan 4, 2022

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 4, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jan 4, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, dsimansk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 4, 2022
@openshift-merge-robot openshift-merge-robot merged commit 9fb3b22 into openshift:release-v0.26.0 Jan 4, 2022
@cardil cardil deleted the backport/0.26/kn-plugin-event/133 branch January 4, 2022 11:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants