Skip to content
This repository has been archived by the owner on Dec 1, 2022. It is now read-only.

[release-v0.26.0] Update kn-plugin-func #902

Conversation

dsimansk
Copy link

@dsimansk dsimansk commented Dec 7, 2021

Midstream repo: https://github.com/openshift-knative/kn-plugin-func

Once the code cut-off is done, Func's midstream repo should contain next release branch, most probably serverless-1.20.

Produced by:

# `@release-next` version value should be replaced by `serverless-1.20` for the final update
go mod edit -replace knative.dev/kn-plugin-func=github.com/openshift-knative/kn-plugin-func@release-next
go mod tidy
go mod vendor

# cleanup
find vendor/ \( -name "OWNERS" -o -name "OWNERS_ALIASES" -o -name "BUILD" -o -name "BUILD.bazel" -o -name "*_test.go" \) -exec rm -f {} +

Sanity check:

➜  client git:(pr/release-v0.26.0-func) ./hack/build.sh -f
🚧 Compile
➜  client git:(pr/release-v0.26.0-func) kn func version         
v0.20.0

@openshift-ci openshift-ci bot requested review from alanfx and matzew December 7, 2021 13:49
@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 7, 2021
@dsimansk dsimansk force-pushed the pr/release-v0.26.0-func branch from 6b91fcd to a8fb510 Compare December 21, 2021 15:05
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 21, 2021
@rhuss
Copy link

rhuss commented Dec 21, 2021

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 21, 2021
@openshift-ci
Copy link

openshift-ci bot commented Dec 21, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Dec 21, 2021

@dsimansk: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 44a91d7 into openshift:release-v0.26.0 Dec 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants