Introduce machineDeployments #990
Conversation
openshift-ci-robot
added
the
size/M
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: enxebre If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
enxebre
force-pushed
the
machine-deployments
branch
from
c93cf08 to
7e968d9
Compare
| @@ -43,10 +46,13 @@ func MachineSets(config *types.InstallConfig, pool *types.MachinePool, role, use | |||
| return nil, errors.Wrap(err, "failed to create provider") | |||
| } | |||
| name := fmt.Sprintf("%s-%s-%s", clustername, pool.Name, az) | |||
| mset := clusterapi.MachineSet{ | |||
| maxSurge := intstr.FromInt(1) | |||
There was a problem hiding this comment.
Maybe put a short comment here "Rolling machines one by one"
|
Consider extending https://github.com/openshift/installer/blob/master/CHANGELOG.md |
enxebre
force-pushed
the
machine-deployments
branch
from
7e968d9 to
9e62aa2
Compare
|
Is this planned to go in for 4.0? If so we will adjust Hive to maintain MachineDeployments instead of MachineSets post-install. |
| // MachineSets returns a list of machinesets for a machinepool. | ||
| func MachineSets(config *types.InstallConfig, pool *types.MachinePool, role, userDataSecret string) ([]clusterapi.MachineSet, error) { | ||
| // MachineDeployments returns a list of machinedeployments for a machinepool. | ||
| func MachineDeployments(config *types.InstallConfig, pool *types.MachinePool, role, userDataSecret string) ([]clusterapi.MachineDeployment, error) { |
There was a problem hiding this comment.
Hive shares this function to maintain post-install, the changes here look fine from my POV.
|
/hold There must be a commit message for something as invasive as this. Please follow our contribution guide and add a thorough description of what this does and (more importantly) why this needs to change. |
openshift-ci-robot
added
do-not-merge/hold
enxebre
force-pushed
the
machine-deployments
branch
from
9e62aa2 to
a2df547
Compare
openshift-ci-robot
removed
the
needs-rebase
|
@enxebre: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
closing for now, I'll reopen when relevant |
This introduces support for machineDeployments.
Deployments rely on sets to allow among other things to roll pool of workers to new types of instances