OCPBUGS-44523: Remove unused variable from ASH arm template 06_workers.json #9204
Conversation
jinyunma
changed the title
openshift-ci-robot
added
jira/severity-low
|
@jinyunma: This pull request references Jira Issue OCPBUGS-44523, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: jinyunma. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lgtm |
|
@jinyunma: This pull request references Jira Issue OCPBUGS-44523, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: jinyunma. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test ci/prow/e2e-azurestack-upi |
|
@gpei: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test e2e-azurestack-upi |
|
Installation in Job e2e-azurestack-upi failed because of bug https://issues.redhat.com/browse/OCPBUGS-43823, worker nodes were provisioned successfully. @patrickdillon @r4f4 could you help to review? thanks. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: r4f4 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
1 similar comment
|
/test e2e-azure-ovn-upi |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/retest-required |
3 similar comments
|
/override ci/prow/e2e-azure-ovn-upi |
|
@r4f4: Overrode contexts on behalf of r4f4: ci/prow/e2e-azure-ovn-upi In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/e2e-azure-ovn |
|
@r4f4: Overrode contexts on behalf of r4f4: ci/prow/e2e-azure-ovn In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@jinyunma: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit fef4be9
into
openshift:master
|
@jinyunma: Jira Issue OCPBUGS-44523: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-44523 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] Distgit: ose-installer-terraform-providers |
|
[ART PR BUILD NOTIFIER] Distgit: ose-installer-altinfra |
|
[ART PR BUILD NOTIFIER] Distgit: ose-baremetal-installer |
|
[ART PR BUILD NOTIFIER] Distgit: ose-installer-artifacts |
|
/cherry-pick release-4.17 |
|
@jinyunma: new pull request created: #9285 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@jinyunma we may need to cherry-pick it to 4.18 too as the master is targeted for 4.19 now. |
|
/cherry-pick release-4.18 |
|
@jinyunma: new pull request created: #9286 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
The content of arm template 06_workers.json in installer repo is shown in official azure stack hub upi installation doc, variables
identityNameis not being used, remove it to avoid confusion from user when creating UPI cluster on azure stack hub.