OCPBUGS-44193: Reduce Server Side Filtering of Resources #9202
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-ci-robot
added
jira/valid-reference
|
@barbacbd: This pull request references Jira Issue OCPBUGS-44193, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cc @patrickdillon |
openshift-ci
bot
requested review from
jianli-wei,
patrickdillon and
andfasano
|
/uncc @andfasano |
barbacbd
force-pushed
the
OCPBUGS-44193_client_side
branch
3 times, most recently
from
0aa2be4 to
54b7290
Compare
barbacbd
force-pushed
the
OCPBUGS-44193_client_side
branch
8 times, most recently
from
3ece7e0 to
9e73bab
Compare
barbacbd
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
barbacbd
force-pushed
the
OCPBUGS-44193_client_side
branch
from
9e73bab to
5a5e34d
Compare
pkg/destroy/gcp/cloudcontroller.go
Outdated
| func (o *ClusterUninstaller) hasClusterIDPrefix(itemName string) bool { | ||
| return o.isClusterResource(itemName) | ||
| } |
There was a problem hiding this comment.
We can consolidate this into a single function, either hasClusterIDPrefix or isClusterResource
** The destroy code is using server side filtering on resources. The number of resources that are filtered out (server side) are causing quota limits to be reached. Moving the filtering to the client side will limit quota max errors.
barbacbd
force-pushed
the
OCPBUGS-44193_client_side
branch
from
5a5e34d to
338e0c9
Compare
|
/retest |
|
/label acknowledge-critical-fixes-only |
openshift-ci
bot
added
the
acknowledge-critical-fixes-only
|
/label platform/google |
|
Fortunately, GCP collects quota data for what we delete, so we can compare the quota for the latest run from this PR with, say, another presubmit Using jd to compare... $ jd -set pr-quota.json presubmit-quota.json
@ ["gcp",["set"],{}]
- {"amount":2,"dimensions":{"network_id":"ci-op-46zmsc2l-6a305-8rbkj-network"},"limit":"subnet_ranges_per_vpc_network","service":"compute.googleapis.com"}
- {"amount":1,"dimensions":{"region":"us-central1"},"limit":"internal_addresses","service":"compute.googleapis.com"}
+ {"amount":1,"dimensions":{"region":""},"limit":"addresses","service":"compute.googleapis.com"}
+ {"amount":40,"dimensions":{"region":"us-central1"},"limit":"disks_total_storage","service":"compute.googleapis.com"}
+ {"amount":1,"dimensions":{"region":"us-central1"},"limit":"addresses","service":"compute.googleapis.com"}
+ {"amount":2,"dimensions":{"network_id":"ci-op-23kt0cp6-6a305-sshhv-network"},"limit":"subnet_ranges_per_vpc_network","service":"compute.googleapis.com"}The first thing that jumps out is it looks like we're leaking disks, so let's /hold until we can check that out. Networks look ok, it's just diffing on the names. Not sure what's going on with addresses. We will need to look more closely. |
openshift-ci
bot
added
the
do-not-merge/hold
|
/approve |
openshift-ci
bot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@barbacbd: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@barbacbd: Jira Issue OCPBUGS-44193: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged:
These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-44193 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cherry-pick release-4.17 |
|
@barbacbd: new pull request created: #9289 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
The destroy code is using server side filtering on resources. The number of resources that
are filtered out (server side) are causing quota limits to be reached. Moving the filtering
to the client side will limit quota max errors.