Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHANGELOG: Document changes since 5813f611 #917

Merged
merged 1 commit into from
Dec 15, 2018
Merged

CHANGELOG: Document changes since 5813f611 #917

merged 1 commit into from
Dec 15, 2018

Conversation

wking
Copy link
Member

@wking wking commented Dec 15, 2018

Covering 5813f61 (#745) through 14505f3 (#911).

CC @abhinavdahiya

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 15, 2018
@wking
CHANGELOG: Document changes since 5813f61
04dda38 
Covering 5813f61 (Merge pull request openshift#745 from wking/s3-vpc-endpoint,
2018-12-13) through 874876e (Merge pull request openshift#711 from
staebler/improve_input_validation, 2018-12-14).
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 15, 2018
@wking
Copy link
Member Author

wking commented Dec 15, 2018

Rebased onto master with f1582d7 -> 04dda38 and updated to document #711 (#757 also landed in that timeframe, but isn't user-facing).

@wking wking mentioned this pull request Dec 15, 2018
Closed
@abhinavdahiya
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [abhinavdahiya,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 67b8bbb into openshift:master Dec 15, 2018
@wking wking deleted the version-0.7.0 branch December 17, 2018 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhinavdahiya abhinavdahiya Awaiting requested review from abhinavdahiya

@russellb russellb Awaiting requested review from russellb

Assignees

@abhinavdahiya abhinavdahiya

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wking @abhinavdahiya @openshift-ci-robot @openshift-merge-robot