-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/openshift-install/create: Drop newline from "Route found..." log #849
cmd/openshift-install/create: Drop newline from "Route found..." log #849
Conversation
Log entries don't need us to set explicit newlines; they're injected by the logger as needed for line-based log receivers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: crawford, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/retest |
/retest |
/retest see if openshift/origin#21641 helps. |
/retest |
Just the one failure:
/retest |
Log entries don't need us to set explicit newlines; they're injected by the logger as needed for line-based log receivers.