Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/openshift-install/create: Drop newline from "Route found..." log #849

Merged

Conversation

wking
Copy link
Member

@wking wking commented Dec 9, 2018

Log entries don't need us to set explicit newlines; they're injected by the logger as needed for line-based log receivers.

Log entries don't need us to set explicit newlines; they're injected
by the logger as needed for line-based log receivers.
@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 9, 2018
Copy link
Contributor

@crawford crawford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 9, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crawford, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wking
Copy link
Member Author

wking commented Dec 10, 2018

/retest

@crawford
Copy link
Contributor

level=fatal msg="Error executing openshift-install: waiting for bootstrap-complete: timed out waiting for the condition"

/retest

@wking
Copy link
Member Author

wking commented Dec 10, 2018

/retest

@wking
Copy link
Member Author

wking commented Dec 10, 2018

/retest

see if openshift/origin#21641 helps.

@wking
Copy link
Member Author

wking commented Dec 10, 2018

/retest

@wking
Copy link
Member Author

wking commented Dec 10, 2018

Just the one failure:

Dec 10 20:02:35.788: INFO: Last cluster version seen: map[status:map[versionHash:7bvzYHWWQ0I= availableUpdates:<nil> conditions:[map[lastTransitionTime:2018-12-10T19:55:57Z status:False type:Available] map[reason:UpdatePayloadFailed status:True type:Failing lastTransitionTime:2018-12-10T19:55:57Z message:Could not update clusteroperator "openshift-cluster-kube-apiserver-operator" (config.openshift.io/v1, 40 of 205)] map[lastTransitionTime:2018-12-10T19:55:57Z message:Unable to apply 0.0.1-2018-12-10-193031: the update could not be applied reason:UpdatePayloadFailed status:True type:Progressing] map[lastTransitionTime:2018-12-10T19:41:11Z message:Unable to retrieve available updates: unexpected HTTP status: 404 Not Found reason:RemoteFailed status:False type:RetrievedUpdates]] current:map[payload:registry.svc.ci.openshift.org/ci-op-6nmkw85c/release@sha256:3514fa69583a2a10ede7b1e7b07c83c77d2e14105b672b7fbb1ec64d02b31a39 version:0.0.1-2018-12-10-193031] generation:%!s(int64=1)] apiVersion:config.openshift.io/v1 kind:ClusterVersion metadata:map[creationTimestamp:2018-12-10T19:40:27Z generation:%!s(int64=1) name:version resourceVersion:12132 selfLink:/apis/config.openshift.io/v1/clusterversions/version uid:71f360cf-fcb3-11e8-a6e5-122e28f48524] spec:map[upstream:http://localhost:8080/graph channel:fast clusterID:6a749da8-120a-49a4-9f84-3558375854e6 overrides:[map[unmanaged:%!s(bool=true) kind:APIService name:v1alpha1.packages.apps.redhat.com]]]]
Dec 10 20:02:35.788: INFO: ClusterVersion is reporting a failure: Could not update clusteroperator "openshift-cluster-kube-apiserver-operator" (config.openshift.io/v1, 40 of 205)
Dec 10 20:02:35.788: INFO: ClusterVersion never became available: Unable to apply 0.0.1-2018-12-10-193031: the update could not be applied
...
failed: (5m2s) 2018-12-10T20:02:35 "[Feature:Platform][Smoke] Managed cluster should start all core operators [Suite:openshift/conformance/parallel] [Suite:openshift/smoke-4]"

/retest

@openshift-merge-robot openshift-merge-robot merged commit e113938 into openshift:master Dec 10, 2018
@wking wking deleted the route-found-log-newline branch December 11, 2018 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants