Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move variables to constants #834

Merged
merged 1 commit into from
Dec 11, 2018
Merged

Move variables to constants #834

merged 1 commit into from
Dec 11, 2018

Conversation

cdrage
Copy link
Contributor

@cdrage cdrage commented Dec 7, 2018

Moves certain variables to constants.

This will make changes such as
#805 easier to implement

@cdrage
Move variables to constants
d120d89 
Moves certain variables to constants.

This will make changes such as
openshift#805 easier to implement
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 7, 2018
@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 7, 2018
@openshift-ci-robot
Copy link
Contributor

Hi @cdrage. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abhinavdahiya
Copy link
Contributor

/ok-to-test

Thanks for the PR @cdrage ! 😄

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 7, 2018
wking
wking reviewed Dec 7, 2018
View reviewed changes
pkg/asset/ignition/bootstrap/bootstrap.go
ign.User = &igntypes.NodeUser{Name: "core"}
ign.Group = &igntypes.NodeGroup{Name: "core"}
ign.User = &igntypes.NodeUser{Name: ignitionUser}
ign.Group = &igntypes.NodeGroup{Name: ignitionUser}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overloading, mumble, mumble. But I'm fine adding an ignitionGroup later if we end up needing it.

@wking
Copy link
Member

wking commented Dec 7, 2018

/lgtm
/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 7, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cdrage, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2018
@wking wking mentioned this pull request Dec 10, 2018
Merged
@abhinavdahiya
Copy link
Contributor

/retest

@openshift-merge-robot openshift-merge-robot merged commit 32128e7 into openshift:master Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wking wking wking left review comments

@aaronlevy aaronlevy Awaiting requested review from aaronlevy

@staebler staebler Awaiting requested review from staebler

Assignees

@wking wking

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cdrage @openshift-ci-robot @abhinavdahiya @wking @openshift-merge-robot