CORS-3254: Update google.golang.org/api/cloudresourcemanager library version #8213
Conversation
|
@bharath-b-rh: This pull request references CORS-3254 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
openshift-merge-robot
added
the
needs-rebase
openshift-merge-robot
removed
the
needs-rebase
|
/cc @r4f4 |
|
/uncc @jhixson74 |
openshift-ci
bot
requested review from
barbacbd and
bfournie
and removed request for
jhixson74
|
|
||
| tagValuesService := cloudresourcemanager.NewTagValuesService(service) | ||
|
|
||
| return tagValuesService.GetNamespaced(). |
There was a problem hiding this comment.
Can we wrap the possible errors here?
There was a problem hiding this comment.
suggestion incorporated.
| } | ||
| return nil | ||
| }); err != nil { | ||
| return nil, err |
There was a problem hiding this comment.
suggestion incorporated.
| "k8s.io/apimachinery/pkg/util/sets" | ||
| ) | ||
|
|
||
| const ( | ||
| // projectNameFmt is the format string for project resource name. | ||
| projectNameFmt = "projects/%s" |
There was a problem hiding this comment.
This is now defined multiple times, consider moving somewhere that both parts of the package can use it.
There was a problem hiding this comment.
suggestion incorporated.
|
@bharath-b-rh: This pull request references CORS-3254 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: r4f4 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@bharath-b-rh: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit 8995dd6
into
openshift:master
This is a continuation of code changes made in #7279 PR where cloudresourcemanager was updated in one of the internal packages and in this PR it is updated other packages using it.
Along with updating the library version, the APIs are also updated/replaced with the new offering from the library.
Make use of the constant
ClusterIDLabelFmtdefined inpkg/constants/gcp/gcp.gofor deriving the label name added to GCP resources created for OpenShift cluster, instead of re-declaring at multiple places.