Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: Consolidate supported-platform documentation #793

Merged

Conversation

wking
Copy link
Member

@wking wking commented Dec 5, 2018

And make it clear that libvirt is development-only, because we're about to remove support for it from released binaries (folks will still be able to build the installer themselves to get the libvirt stuff).

CC @crawford

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 5, 2018
And make it clear that libvirt is development-only, because we're
about to remove support for it from released binaries (folks will
still be able to build the installer themselves to get the libvirt
stuff).
@wking wking force-pushed the libvirt-support-status branch from 1cad19d to 86caa99 Compare December 5, 2018 20:55
@crawford
Copy link
Contributor

crawford commented Dec 7, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 7, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crawford, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wking
Copy link
Member Author

wking commented Dec 7, 2018

images:

error: uploading the source layer sha256:ca9154981764613b2849b53c599da7a3a7037f772173af642815c3e91bea7060 failed: unable to upload layer sha256:ca9154981764613b2849b53c599da7a3a7037f772173af642815c3e91bea7060 to destination repository: unknown blob

/retest

@wking
Copy link
Member Author

wking commented Dec 10, 2018

/retest

@wking
Copy link
Member Author

wking commented Dec 10, 2018

/retest

@openshift-merge-robot openshift-merge-robot merged commit 2e1d6b3 into openshift:master Dec 10, 2018
@wking wking deleted the libvirt-support-status branch December 11, 2018 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants