Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug OCPBUGS-16249: Add ip=dhcp,dhcp6 option to Kernel args #7367

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Bug OCPBUGS-16249: Add ip=dhcp,dhcp6 option to Kernel args #7367

merged 1 commit into from
Aug 2, 2023

Conversation

MaysaMacedo
Copy link
Contributor

@MaysaMacedo MaysaMacedo commented Jul 25, 2023 •
edited
Loading

On clusters configured with dual-stack network the
IPv4 and IPv6 addresses can be added to the main interface
at different time, which results in the openshift node addresses
not containing the IPv6 address. This commit fixes the issue
by including ip=dhcp,dhcp6 to the kernel args of masters and works,
which sets required-timeout to an value that the IP configuration
will be tried before succeeds. This configuration is valid for day1
dual-stack clusters only.

Partially Implements: openshift/enhancements#1365

@openshift-ci openshift-ci bot requested review from andfasano and r4f4 July 25, 2023 14:46
@MaysaMacedo
Copy link
Contributor Author

MaysaMacedo commented Jul 25, 2023 •
edited
Loading

Here there are details on why ip=dhcp,dhcp6 helps with the timing issue.

The following are the settings added with ip=dhcp,dhcp6:

$ /usr/libexec/nm-initrd-generator -s -- ip=dhcp,dhcp6
*** Configuration '15-carrier-timeout.conf' ***
[device-15-carrier-timeout]
match-device=*
carrier-wait-timeout=10000
[.config]
enable=env:initrd
*** Connection 'default_connection' ***
[connection]
id=Wired Connection
uuid=9d45bc82-f499-4a60-829e-1e1a6342f8be
type=ethernet
autoconnect-priority=-100
autoconnect-retries=1
multi-connect=3
[ethernet]
[ipv4]
dhcp-timeout=90
method=auto
required-timeout=20000
[ipv6]
dhcp-timeout=90
method=auto
required-timeout=20000
[proxy]
[user]
org.freedesktop.NetworkManager.origin=nm-initrd-generator

The config got applied correctly. There was an known issue with systemd-network-generator.service but it seems to be tracked by this bugzilla:

[core@ostest-n7tzh-master-0 ~]$ sudo journalctl -u systemd-network-generator.service
Jul 25 13:19:26 ostest-n7tzh-master-0 systemd[1]: systemd-network-generator.service: Deactivated successfully.
Jul 25 13:19:26 ostest-n7tzh-master-0 systemd[1]: Stopped Generate network units from Kernel command line.
-- Boot 36e45f7edefd47df85a1239de2264c8e --
Jul 25 13:19:39 ostest-n7tzh-master-0 systemd-network-generator[766]: Failed to parse kernel command line: Invalid argument

@MaysaMacedo MaysaMacedo changed the title Add ip=dhcp,dhcp6 option to Kernel args Bug OCPBUGS-16249: Add ip=dhcp,dhcp6 option to Kernel args Jul 25, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jul 25, 2023
@openshift-ci-robot
Copy link
Contributor

@MaysaMacedo: This pull request references Jira Issue OCPBUGS-16249, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sergiordlr

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

On clusters configured with dual-stack network the IPv4 and IPv6 addresses can be added to the main interface at different time, which results in the openshift node addresses not containing the IPv6 address. This commit fixes the issue by including ip=dhcp,dhcp6 to the kernel args of masters and works, which set required-timeout to an value that the IP configuration will be tried before succeeds.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from sergiordlr July 25, 2023 15:40
@MaysaMacedo
Copy link
Contributor Author

/cc @mandre

@openshift-ci openshift-ci bot requested a review from mandre July 25, 2023 17:39
@MaysaMacedo MaysaMacedo mentioned this pull request Jul 25, 2023
Merged
@MaysaMacedo
Copy link
Contributor Author

/retest-required

mandre
mandre reviewed Jul 26, 2023
View reviewed changes
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if we had tests, in the form of unit tests and/or manifests test (like I did in #7363) to verify we correctly generate the manifest adding the kernel option.

pkg/asset/machines/machineconfig/ipv6.go Outdated Show resolved Hide resolved
@openshift-ci-robot
Copy link
Contributor

@MaysaMacedo: This pull request references Jira Issue OCPBUGS-16249, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sergiordlr

In response to this:

On clusters configured with dual-stack network the IPv4 and IPv6 addresses can be added to the main interface at different time, which results in the openshift node addresses not containing the IPv6 address. This commit fixes the issue by including ip=dhcp,dhcp6 to the kernel args of masters and works, which set required-timeout to an value that the IP configuration will be tried before succeeds.

Partially Implements: openshift/enhancements#1365

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@MaysaMacedo: This pull request references Jira Issue OCPBUGS-16249, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sergiordlr

In response to this:

On clusters configured with dual-stack network the
IPv4 and IPv6 addresses can be added to the main interface
at different time, which results in the openshift node addresses
not containing the IPv6 address. This commit fixes the issue
by including ip=dhcp,dhcp6 to the kernel args of masters and works,
which sets required-timeout to an value that the IP configuration
will be tried before succeeds. This configuration is valid for day1
dual-stack clusters only.

Partially Implements: openshift/enhancements#1365

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@MaysaMacedo
Copy link
Contributor Author

Note that this configuration is only enforced for day-1 dual-stack clusters. Once we start working on conversion to dual-stack clusters we will need to figure out one additional way on how to apply this config.

@MaysaMacedo MaysaMacedo force-pushed the configure-ipv6 branch 2 times, most recently from da450ae to 691a196 Compare July 31, 2023 19:18
@EmilienM
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2023
@EmilienM
Copy link
Member

/lgtm

@MaysaMacedo
Add ip=dhcp,dhcp6 option to Kernel args
641857f 
On clusters configured with dual-stack network the
IPv4 and IPv6 addresses can be added to the main interface
at different time, which results in the openshift node addresses
not containing the IPv6 address. This commit fixes the issue
by including `ip=dhcp,dhcp6` to the kernel args of masters and works,
which sets `required-timeout` to an value that the IP configuration
will be tried before succeeds. This configuration is valid for day1
dual-stack clusters only.
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2023
@EmilienM
Copy link
Member

/lgtm

@MaysaMacedo
Copy link
Contributor Author

/assign @r4f4

mandre
mandre reviewed Aug 1, 2023
View reviewed changes
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

r4f4
r4f4 reviewed Aug 1, 2023
View reviewed changes
Copy link
Contributor

@r4f4 r4f4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre, r4f4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 2e5b7f6 and 2 for PR HEAD 641857f in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 1, 2023 •
edited
Loading

@MaysaMacedo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 641857f link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-openstack-nfv-intel 641857f link false /test e2e-openstack-nfv-intel
ci/prow/okd-e2e-aws-ovn-upgrade 641857f link false /test okd-e2e-aws-ovn-upgrade
ci/prow/okd-e2e-aws-ovn 641857f link false /test okd-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@MaysaMacedo
Copy link
Contributor Author

/test e2e-aws-ovn

@MaysaMacedo
Copy link
Contributor Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit a3fa7e0 into openshift:master Aug 2, 2023
@openshift-ci-robot
Copy link
Contributor

@MaysaMacedo: Jira Issue OCPBUGS-16249: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-16249 has been moved to the MODIFIED state.

In response to this:

On clusters configured with dual-stack network the
IPv4 and IPv6 addresses can be added to the main interface
at different time, which results in the openshift node addresses
not containing the IPv6 address. This commit fixes the issue
by including ip=dhcp,dhcp6 to the kernel args of masters and works,
which sets required-timeout to an value that the IP configuration
will be tried before succeeds. This configuration is valid for day1
dual-stack clusters only.

Partially Implements: openshift/enhancements#1365

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@MaysaMacedo MaysaMacedo deleted the configure-ipv6 branch October 26, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkowalski mkowalski mkowalski left review comments

@EmilienM EmilienM EmilienM left review comments

@mandre mandre mandre left review comments

@r4f4 r4f4 r4f4 left review comments

@andfasano andfasano Awaiting requested review from andfasano

@sergiordlr sergiordlr Awaiting requested review from sergiordlr

Assignees

@r4f4 r4f4

@EmilienM EmilienM

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@MaysaMacedo @openshift-ci-robot @EmilienM @r4f4 @mandre @mkowalski @openshift-merge-robot