Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts for nested-libvirt ci #625

Merged

Conversation

sallyom
Copy link
Contributor

@sallyom sallyom commented Nov 6, 2018

This PR enables testing of libvirt cluster in a GCE instance, for a CI job to ensure developer libvirt workflow is not broken.

@sallyom sallyom changed the title scripts for nested-libvirt ci [WIP] scripts for nested-libvirt ci Nov 6, 2018
@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 6, 2018
@sallyom sallyom force-pushed the danmace-libvirt-scripts branch from 7ba9ca8 to 4d09cae Compare November 6, 2018 19:16
@sallyom sallyom force-pushed the danmace-libvirt-scripts branch 5 times, most recently from 0a6764e to 38f8a62 Compare November 7, 2018 16:49
@sallyom sallyom changed the title [WIP] scripts for nested-libvirt ci scripts for nested-libvirt ci Nov 7, 2018
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 7, 2018
@sallyom sallyom force-pushed the danmace-libvirt-scripts branch from 38f8a62 to e776c9b Compare November 8, 2018 00:29
@sallyom sallyom force-pushed the danmace-libvirt-scripts branch from e776c9b to 88c0aff Compare November 8, 2018 14:32
images/installer/nested-libvirt/README.md Outdated Show resolved Hide resolved
images/installer/nested-libvirt/README.md Outdated Show resolved Hide resolved
images/installer/nested-libvirt/README.md Outdated Show resolved Hide resolved
images/installer/nested-libvirt/README.md Outdated Show resolved Hide resolved
images/installer/nested-libvirt/README.md Outdated Show resolved Hide resolved
images/installer/nested-libvirt/README.md Outdated Show resolved Hide resolved
images/installer/nested-libvirt/generate-user.sh Outdated Show resolved Hide resolved
images/installer/nested-libvirt/README.md Outdated Show resolved Hide resolved
scripts/nested-libvirt/router-check.sh Outdated Show resolved Hide resolved
scripts/nested-libvirt/router-check.sh Outdated Show resolved Hide resolved
@sallyom sallyom force-pushed the danmace-libvirt-scripts branch 3 times, most recently from 0e277d9 to c0d58e9 Compare November 9, 2018 14:27
@sallyom
Copy link
Contributor Author

sallyom commented Nov 9, 2018

@wking i've added a timeout to the router-check, and I've updated the Dockerfile for CI image pipeline:libvirt-installer to include openshift-install binary to be scp'd over to the GCE instance : ) .

@sallyom sallyom force-pushed the danmace-libvirt-scripts branch from c0d58e9 to 37b661b Compare November 12, 2018 12:59
@sallyom
Copy link
Contributor Author

sallyom commented Nov 12, 2018

/test e2e-aws

images/installer/nested-libvirt/Dockerfile Outdated Show resolved Hide resolved
images/installer/nested-libvirt/Dockerfile Outdated Show resolved Hide resolved
images/installer/nested-libvirt/README.md Outdated Show resolved Hide resolved
images/installer/nested-libvirt/README.md Outdated Show resolved Hide resolved
images/installer/nested-libvirt/mock-nss.sh Outdated Show resolved Hide resolved
scripts/ci/router-check.sh Outdated Show resolved Hide resolved
scripts/ci/router-check.sh Outdated Show resolved Hide resolved
scripts/ci/router-check.sh Outdated Show resolved Hide resolved
@sallyom sallyom force-pushed the danmace-libvirt-scripts branch from abae4bc to ff4b4a1 Compare November 13, 2018 23:26
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 13, 2018
@sallyom sallyom force-pushed the danmace-libvirt-scripts branch from ff4b4a1 to 8c3b446 Compare November 13, 2018 23:32
@sallyom sallyom force-pushed the danmace-libvirt-scripts branch 2 times, most recently from 98addd6 to db596ed Compare November 14, 2018 00:53
@sallyom sallyom force-pushed the danmace-libvirt-scripts branch from db596ed to c0ae66f Compare November 14, 2018 00:56
images/nested-libvirt/README.md Outdated Show resolved Hide resolved
images/nested-libvirt/README.md Show resolved Hide resolved
@sallyom sallyom force-pushed the danmace-libvirt-scripts branch 2 times, most recently from f818249 to 16ef2cf Compare November 14, 2018 01:25
@sallyom sallyom force-pushed the danmace-libvirt-scripts branch 2 times, most recently from b688b87 to 8ffd595 Compare November 14, 2018 12:25
@sallyom
Copy link
Contributor Author

sallyom commented Nov 14, 2018

@abhinavdahiya I moved the router-check logic to release repo (to be replaced with actual conformance tests when e2e-aws also does, I'm keeping checks with libvirt in line with e2e-aws checks).

Copy link
Member

@wking wking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 14, 2018
@wking wking dismissed abhinavdahiya’s stale review November 14, 2018 17:08

router check logic moved to the release repo: #625 (comment)

@sallyom sallyom force-pushed the danmace-libvirt-scripts branch from 8ffd595 to 652b825 Compare November 14, 2018 17:58
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 14, 2018
@wking
Copy link
Member

wking commented Nov 14, 2018

images error is openshift/release#2070.

/retest
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 14, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sallyom, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 31dfbd9 into openshift:master Nov 14, 2018
@wking wking mentioned this pull request Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants