Add support for private DNS server to PowerVS

[hamzy]

This adds support for a private DNS server to PowerVS by
conditionally creating resources based on:
publish: Internal
in the install-config.yaml

[mjturek]

Looking good so far! Left some comments. Also I think we should adjust commit message to something like:

"Power VS: Conditionally create VPC VM for proxy DNS"

[mjturek]

LGTM - can you remove WIP?

[hamzy]

/retest-required

[mjturek]

/lgtm

[hamzy]

/retest

[hamzy]

/retest-required

[hamzy]

/retest-required

[clnperez]

@rna-afk can we get a review on this one?

[openshift-ci]

@hamzy: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-ovirt	b98d774	link	false	/test e2e-ovirt
ci/prow/e2e-openstack	b98d774	link	false	/test e2e-openstack

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[hamzy]

/retest-required

[mjturek]

would you be opposed to moving VM creation into the power_network module rather than dns?

It would simplify using the VM as a proxy DHCP service by allowing the dhcp service resouce to directly read the IP from the proxy VM after it's created rather than relying on an output

EDIT: Discussed offline and decided to keep PR as is.

[mjturek]

/lgtm

[rna-afk]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rna-afk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rna-afk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment