Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vendor: Bump k8s.io/client-go to 9.0.0 and apimachinery to 1.12.2 #574

Closed
wants to merge 2 commits into from
Closed

vendor: Bump k8s.io/client-go to 9.0.0 and apimachinery to 1.12.2 #574

wants to merge 2 commits into from

Conversation

wking
Copy link
Member

@wking wking commented Oct 30, 2018

client-go 9.0.0 is compatible with Kubernetes 1.12, and I want this for UntilWithoutRetry which is new in 9.0.0.

I edited Gopkg.toml by hand and regenerated everything else with:

$ dep ensure

using:

$ dep version
dep:
 version     : v0.5.0
 build date  :
 git hash    : 22125cf
 go version  : go1.10.3
 go compiler : gc
 platform    : linux/amd64
 features    : ImportDuringSolve=false

Our last Kubernetes bump was apimachinery in #382.

wking added 2 commits October 30, 2018 13:20
@wking
vendor: Bump k8s.io/client-go to 8.0.0
290d57c 
That's the version that's compatible with Kubernetes 1.11 [1], and
we've been using Kubernetes 1.11.3 for apimachinery since 2a606ef
(vendor: bump apimachinery to 1.11.3, 2018-10-01, openshift#382).

I edited Gopkg.toml by hand and regenerated everything else with:

  $ dep ensure

using:

  $ dep version
  dep:
   version     : v0.5.0
   build date  :
   git hash    : 22125cf
   go version  : go1.10.3
   go compiler : gc
   platform    : linux/amd64
   features    : ImportDuringSolve=false

[1]: kubernetes/client-go@7d04d0e
@wking
vendor: Bump k8s.io/client-go to 9.0.0 and apimachinery to 1.12.2
a7b6b9a 
client-go 9.0.0 is compatible with Kubernetes 1.12 [1], and I want
this for UntilWithoutRetry [2] which is new in 9.0.0 [3].

I edited Gopkg.toml by hand and regenerated everything else with:

  $ dep ensure

using:

  $ dep version
  dep:
   version     : v0.5.0
   build date  :
   git hash    : 22125cf
   go version  : go1.10.3
   go compiler : gc
   platform    : linux/amd64
   features    : ImportDuringSolve=false

[1]: kubernetes/client-go@1638f89
[2]: https://github.com/kubernetes/client-go/blob/v9.0.0/tools/watch/until.go#L47-L58
[3]: kubernetes/client-go@cbdb98d
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 30, 2018
@abhinavdahiya
Copy link
Contributor

i'm not sure if we can support 1.12 with additions happening here #573 #567

@wking wking mentioned this pull request Oct 31, 2018
Merged
@wking
Copy link
Member Author

wking commented Oct 31, 2018

I thought this might be easier to revie without semantic changes, but @abhinavdahiya wants it all together.

/close

@openshift-ci-robot
Copy link
Contributor

@wking: Closing this PR.

In response to this:

I thought this might be easier to revie without semantic changes, but @abhinavdahiya wants it all together.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crawford crawford Awaiting requested review from crawford

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wking @openshift-ci-robot @abhinavdahiya