pkg/destroy/libvirt: Add behind a libvirt_destroy build tag

[wking]

Docs for Go's build constraints are here. This pull request allows folks with local libvirt C libraries to compile our libvirt deletion logic (and get a dynamically-linked executable), while release binaries and folks without libvirt C libraries can continue to get statically-linked executables that lack libvirt deletion.

/assign @abhinavdahiya

Testing this locally, I'm getting:

$ env | grep OPENSHIFT_INSTALL_ | sort
OPENSHIFT_INSTALL_BASE_DOMAIN=installer.testing
OPENSHIFT_INSTALL_CLUSTER_NAME=wking
OPENSHIFT_INSTALL_DATA=/home/trking/src/openshift/installer/data/data
[email protected]
OPENSHIFT_INSTALL_LIBVIRT_IMAGE=http://aos-ostree.rhev-ci-vms.eng.rdu2.redhat.com/rhcos/images/cloud/latest/rhcos-qemu.qcow2.gz
OPENSHIFT_INSTALL_LIBVIRT_URI=qemu+tcp://192.168.122.1/system
OPENSHIFT_INSTALL_PASSWORD=asdf
OPENSHIFT_INSTALL_PLATFORM=libvirt
OPENSHIFT_INSTALL_PULL_SECRET_PATH=/home/trking/src/openshift/installer/pull-secret.json
OPENSHIFT_INSTALL_SSH_PUB_KEY_PATH=/home/trking/.ssh/id_rsa.pub
$ openshift-install --log-level=debug cluster
...
DEBU[0021] Generating Cluster...                        
FATA[0021] failed to generate asset: failed to generate asset "Cluster": failed to run Terraform: signal: segmentation fault 

Dunno what's going on there yet.

[wking]

I get the segfault in master too, so it's probably orthogonal. I'm digging into it now.

[wking]

FATA[0021] failed to generate asset: failed to generate asset "Cluster": failed to run Terraform: signal: segmentation fault

This was from a corrupted terraform:

$ sha1sum bin/terraform ~/bin/terraform-0.11.8 
5aa0067541c0273bb650ed89be3b1b1f4dc83944  bin/terraform
06339cdd7a39657355e5c4b04e12efc91672a450  /home/trking/bin/terraform-0.11.8

Pulling a fresh copy with hack/get-terraform.sh got me the 0633... hash in bin/terraform and fixed the issue.

[crawford]

Can we hide all of this behind the dev mode? Developers are the only ones that will use libvirt and since it's likely that they are compiling the installer locally, cgo should play nicely.

[wking]

Can we hide all of this behind the dev mode? Developers are the only ones that will use libvirt and since it's likely that they are compiling the installer locally, cgo should play nicely.

@steveej, at least, had issues with dynamic linking (so he might want dev-mode's lack of compiled-in Terraform without libvirt deletion). And @abhinavdahiya would prefer not to have to mess with OPENSHIFT_INSTALL_DATA (so he might want release-mode's compiled-in Terraform with libvirt deletion). But if you can convince either of them, I'm happy to update the code ;).

[crawford]

Looks good. Can you add a quick note to the docs regarding the build tag?

[wking]

Can you add a quick note to the docs regarding the build tag?

Done with d0feed5 -> c5fb068.

[wking]

And rebased around #384 with c5fb068 -> 4d940ce.

[crawford]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crawford, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [crawford,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment