Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes missed in PR #372 #376

Merged
merged 1 commit into from
Sep 29, 2018
Merged

fixes missed in PR #372 #376

merged 1 commit into from
Sep 29, 2018

Conversation

abhinavdahiya
Copy link
Contributor

/cc @crawford

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 28, 2018
@abhinavdahiya abhinavdahiya mentioned this pull request Sep 28, 2018
Merged
@crawford
Copy link
Contributor

Can we rename "URI" to "Libvirt Connection URI"?

@abhinavdahiya
Copy link
Contributor Author

@wking recommended Libvirtd URI. Any preference between Libvirt Connection URI and Libvirtd URI

@crawford
Copy link
Contributor

https://libvirt.org/uri.html refers to them as Connection URIs.

@crawford
Copy link
Contributor

/approve

@wking
Copy link
Member

wking commented Sep 28, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 28, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, crawford, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [abhinavdahiya,crawford,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@wking
Copy link
Member

wking commented Sep 29, 2018

/hold

Wait on #379.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 29, 2018
@wking
Copy link
Member

wking commented Sep 29, 2018

#379 merged

/hold cancel
/retest

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 29, 2018
@openshift-merge-robot openshift-merge-robot merged commit 3b68ffb into openshift:master Sep 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crawford crawford Awaiting requested review from crawford

Assignees

@wking wking

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@abhinavdahiya @crawford @wking @openshift-ci-robot @openshift-bot @openshift-merge-robot