data/data/bootstrap/files/usr/local/bin/release-image-download: Drop --quiet

[wking]

We've had the option since 9dfdc3c (#1293). But since d1ec85a (#2234) that image pull has happened in a separate unit, so output will be in journals/release-image.log and not cluttering up journals/bootkube.log. So get noisy again, to get information like:

$ podman pull quay.io/openshift-release-dev/ocp-release-nightly@sha256:542a73a1c3a7ce5e8fa89ea3cd8a9c346dec1f0d437cf7e40bcb773683770be1
Trying to pull quay.io/openshift-release-dev/ocp-release-nightly@sha256:542a73a1c3a7ce5e8fa89ea3cd8a9c346dec1f0d437cf7e40bcb773683770be1...Failed
error pulling image "quay.io/openshift-release-dev/ocp-release-nightly@sha256:542a73a1c3a7ce5e8fa89ea3cd8a9c346dec1f0d437cf7e40bcb773683770be1": unable to pull quay.io/openshift-release-dev/ocp-release-nightly@sha256:542a73a1c3a7ce5e8fa89ea3cd8a9c346dec1f0d437cf7e40bcb773683770be1: unable to pull image: Error determining manifest MIME type for docker://quay.io/openshift-release-dev/ocp-release-nightly@sha256:542a73a1c3a7ce5e8fa89ea3cd8a9c346dec1f0d437cf7e40bcb773683770be1: unexpected http code: 500 (Internal Server Error), URL: https://quay.io/v2/auth?scope=repository%3Aopenshift-release-dev%2Focp-release-nightly%3Apull&service=quay.io

instead of silence like:

-- Logs begin at Tue 2020-05-19 18:47:10 UTC, end at Tue 2020-05-19 19:12:00 UTC. --
May 19 18:47:40 ip-10-0-29-43 systemd[1]: Starting Download the OpenShift Release Image...
May 19 18:47:40 ip-10-0-29-43 release-image-download.sh[1747]: Pulling quay.io/openshift-release-dev/ocp-release-nightly@sha256:542a73a1c3a7ce5e8fa89ea3cd8a9c346dec1f0d437cf7e40bcb773683770be1...
May 19 18:47:41 ip-10-0-29-43 podman[1749]: 2020-05-19 18:47:41.135323376 +0000 UTC m=+0.318008863 system refresh

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign wking
You can assign the PR to them by writing /assign @wking in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[abhinavdahiya]

qq: as long as we get the error, which I think we do even with --quiet, why also get details?

[openshift-ci-robot]

@wking: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-ovirt	0da1087	link	/test e2e-ovirt
ci/prow/e2e-libvirt	0da1087	link	/test e2e-libvirt
ci/prow/e2e-aws-fips	0da1087	link	/test e2e-aws-fips
ci/prow/e2e-aws	0da1087	link	/test e2e-aws
ci/prow/e2e-aws-scaleup-rhel7	0da1087	link	/test e2e-aws-scaleup-rhel7
ci/prow/e2e-aws-upgrade	0da1087	link	/test e2e-aws-upgrade

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[wking]

qq: as long as we get the error, which I think we do even with --quiet, why also get details?

Huh, you're right:

$ podman pull --quiet quay.io/openshift-release-dev/ocp-release-nightly@sha256:542a73a1c3a7ce5e8fa89ea3cd8a9c346dec1f0d437cf7e40bcb773683770be1
error pulling image "quay.io/openshift-release-dev/ocp-release-nightly@sha256:542a73a1c3a7ce5e8fa89ea3cd8a9c346dec1f0d437cf7e40bcb773683770be1": unable to pull quay.io/openshift-release-dev/ocp-release-nightly@sha256:542a73a1c3a7ce5e8fa89ea3cd8a9c346dec1f0d437cf7e40bcb773683770be1: unable to pull image: Error determining manifest MIME type for docker://quay.io/openshift-release-dev/ocp-release-nightly@sha256:542a73a1c3a7ce5e8fa89ea3cd8a9c346dec1f0d437cf7e40bcb773683770be1: unexpected http code: 500 (Internal Server Error), URL: https://quay.io/v2/auth?scope=repository%3Aopenshift-release-dev%2Focp-release-nightly%3Apull&service=quay.io

Not clear to me what information --quiet is actually suppressing; maybe just the Copying blob ... from your #1293. So feel free to close if you see no point, or to merge if you agree that --quiet is no longer needed now that this is a separate unit's log and not bootkube.

[abhinavdahiya]

#3625 (comment)

Even though release-image download is separate unit, non-quiet has capability to create noise and it wouldn't be nice in release-image download unit logs. So closing it for now.

if we find cases where non-quiet is required for debugging, we can revisit.

/close

[openshift-ci-robot]

@abhinavdahiya: Closed this PR.

In response to this:

#3625 (comment)

Even though release-image download is separate unit, non-quiet has capability to create noise and it wouldn't be nice in release-image download unit logs. So closing it for now.

if we find cases where non-quiet is required for debugging, we can revisit.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.