libvirt_prefix_deprovision: Fix "for name that are" -> "names" #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
approved
russellb
reviewed
Sep 26, 2018
| @@ -14,7 +14,7 @@ import ( | |||
| // returns true, when the name should be handled. | |||
| type filterFunc func(name string) bool | |||
|
|
|||
| // ClusterNamePrefixFilter returns true for name | |||
| // ClusterNamePrefixFilter returns true for names | |||
There was a problem hiding this comment.
Same change could be made down on L30.
There was a problem hiding this comment.
... and it's odd that the AlwaysTrueFilter does not always return true. :-)
There was a problem hiding this comment.
Same change could be made down on L30.
Fixed there too with cd617f8 -> dd82979.
"are" is for plurals, "name" was singular.
wking
force-pushed
the
for-name-typo
branch
from
cd617f8 to
dd82979
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: crawford, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"are" is for plurals, "name" was singular. Spun off from here, in case @abhinavdahiya missed my parting argument there ;).