Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tectonic manifests #304

Merged
merged 2 commits into from
Sep 21, 2018
Merged

tectonic manifests #304

merged 2 commits into from
Sep 21, 2018

Conversation

rajatchopra
Copy link

asset/manifests: tectonic manifests

  1. tectonic manifest creation
  2. move file structure to match current installer flow

@crawford @abhinavdahiya PTAL. Tested by hand.

@openshift-ci-robot openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 21, 2018
@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented Sep 21, 2018 •
edited
Loading

move file structure to match current installer flow

Not sure what you mean by that.

These files don't end up in modules/*/resouces; these files go into manifests/ and tectonic/ dirs.

Also can you leave the previous manifest package as is, and all tectonic manifests in tectonic asset.

Also take a look at this , 53b40ce, you should be naming Contents accordingly

@crawford
Copy link
Contributor

Please break this into multiple commits if you are going to move stuff and add stuff in this PR.

@rajatchopra
Copy link
Author

move file structure to match current installer flow

Not sure what you mean by that.

These files don't end up in modules/*/resouces; these files go into manifests/ and tectonic/ dirs.

Also can you leave the previous manifest package as is, and all tectonic manifests in tectonic asset.

I was going to move the manifests to their respective operators as well. Just splitting into manifests and tectonic is enough then?

Also take a look at this , 53b40ce, you should be naming Contents accordingly

@crawford
Copy link
Contributor

Just splitting into manifests and tectonic is enough then?

Yes, for now that is fine.

Rajat Chopra added 2 commits September 21, 2018 14:28
asset/manifests:
0c9c4fe 
Moved content/*go to content/bootkube/*go to make way for tectonic templates. Other cosmetic changes for functions of manifest asset structure.
asset/manifests:
dc4a94c 
Create tectonic manifest files from templates. Tectonic is an asset as well
@rajatchopra
Copy link
Author

Also can you leave the previous manifest package as is, and all tectonic manifests in tectonic asset.

Done. Its a new asset. And is called from the top level target as a step.

@abhinavdahiya
Copy link
Contributor

/lgtm
/hold
@crawford /hold cancel when you think its /lgtm

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Sep 21, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, rajatchopra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [abhinavdahiya,rajatchopra]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@crawford
Copy link
Contributor

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 21, 2018
@openshift-merge-robot openshift-merge-robot merged commit dc4764d into openshift:master Sep 21, 2018
@rajatchopra rajatchopra deleted the operators_wip branch October 11, 2018 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronlevy aaronlevy Awaiting requested review from aaronlevy

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@abhinavdahiya abhinavdahiya

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rajatchopra @abhinavdahiya @crawford @openshift-ci-robot @openshift-merge-robot