data/bootstrap/files/etc/motd: Mention release-image.service #2884
Conversation
openshift-ci-robot
added
the
size/XS
wking
force-pushed
the
motd-mention-release-image-service
branch
from
a419c02 to
f15a406
Compare
|
Thanks, lgtm /cherry-pick release-4.3 |
|
@smarterclayton: once the present PR merges, I will cherry-pick it on top of release-4.3 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
why do we want to add this service to the message? bootkube.sh is the primary one that people should care about. |
|
/lgtm nit: maybe recommend a single call with |
Catching up with d1ec85a (data/bootstrap: extract ironic images from release image, 2019-08-19, openshift#2234).
wking
force-pushed
the
motd-mention-release-image-service
branch
from
f15a406 to
8626b5e
Compare
Done with f15a40645 -> 8626b5e.
And release-image is a prereq. But probably not the only prereq. I'm also fine dropping this MoTD completely and assuming folks know how to investigate systemd services. #2569 would help catch things like insufficient registry auth once the user waited long enough for the installer to give up and scrape down logs. @smarterclayton suggested also possibly reducing inside-the-script retries like this endless loop so folks looking for failing units would notice the pull failures. I'm fine with anything in this space, and while mentioning this unit in the MoTD seemed like a cheap win, I'm fine with any combination of the above possibilities (and likely additional ideas not listed above) to make it easier for users to discover why their install is stuck. |
|
/retest |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, jstuever The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
7 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/skip |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
5 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@wking: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@smarterclayton: new pull request created: #3143 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Catching up with d1ec85a (#2234).