Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1784624: baremetal: Enable the baremetal platform to override the default rhcos images #2757

Merged
merged 1 commit into from
Dec 17, 2019
Merged

Bug 1784624: baremetal: Enable the baremetal platform to override the default rhcos images #2757

merged 1 commit into from
Dec 17, 2019

Conversation

kirankt
Copy link
Contributor

@kirankt kirankt commented Dec 5, 2019

What Changed?
Addition of two new configuration parameters in the Baremetal platform

Why?
Gives the baremetal platform to override the default rhcos image by specifying an alternate URL to download images for bootstrap node and cluster nodes.

#2597

@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 5, 2019
@openshift-ci-robot
Copy link
Contributor

Hi @kirankt. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 5, 2019
@stbenjam stbenjam mentioned this pull request Dec 5, 2019
Closed
@kirankt kirankt requested a review from stbenjam December 5, 2019 20:27
@stbenjam
Copy link
Member

stbenjam commented Dec 5, 2019

Looks good to me, generally. I think the only thing that's missing is adding an example to https://github.com/openshift/installer/blob/master/docs/user/metal/install_ipi.md#install-config

/assign @abhinavdahiya
/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 5, 2019
@stbenjam
Copy link
Member

stbenjam commented Dec 5, 2019

/label platform/baremetal

@openshift-ci-robot openshift-ci-robot added the platform/baremetal IPI bare metal hosts platform label Dec 5, 2019
@metal3ci
Copy link

metal3ci commented Dec 6, 2019

Build SUCCESS, see build http://10.8.144.11:8080/job/dev-tools/1350/

hardys
hardys reviewed Dec 6, 2019
View reviewed changes
pkg/asset/rhcos/image.go Outdated Show resolved Hide resolved
@hardys
Copy link
Contributor

hardys commented Dec 6, 2019

Couple of nits re the logging but otherwise lgtm

stbenjam
stbenjam suggested changes Dec 6, 2019
View reviewed changes
Copy link
Member

@stbenjam stbenjam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, just a couple of minor comments and I think it's good to go.

One small other thing would be to adjust the commit style, https://github.com/openshift/installer/blob/master/CONTRIBUTING.md#commit-message-format

It should be prefixed by baremetal: (the installer team will ask for this when they review)

pkg/asset/rhcos/bootstrap_image.go Outdated Show resolved Hide resolved
pkg/types/baremetal/platform.go Outdated Show resolved Hide resolved
pkg/types/baremetal/platform.go Outdated Show resolved Hide resolved
@kirankt kirankt changed the title Enable the baremetal platform to override the default rhcos images baremetal: Enable the baremetal platform to override the default rhcos images Dec 6, 2019
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 6, 2019
@metal3ci
Copy link

metal3ci commented Dec 6, 2019

Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/1353/

@stbenjam
Copy link
Member

stbenjam commented Dec 6, 2019

/lgtm

@abhinavdahiya PTAL, thanks!

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2019
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

13 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 1a0c61f into openshift:master Dec 17, 2019
@stbenjam
Copy link
Member

/cherry-pick release-4.3

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 17, 2019
Merged
@openshift-cherrypick-robot
Copy link

@stbenjam: new pull request created: #2835

In response to this:

/cherry-pick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stbenjam
Copy link
Member

/retitle Bug 1784624: baremetal: Enable the baremetal platform to override the default rhcos images

@openshift-ci-robot openshift-ci-robot changed the title baremetal: Enable the baremetal platform to override the default rhcos images Bug 1784624: baremetal: Enable the baremetal platform to override the default rhcos images Dec 17, 2019
@openshift-ci-robot
Copy link
Contributor

@kirankt: All pull requests linked via external trackers have merged. Bugzilla bug 1784624 has been moved to the MODIFIED state.

In response to this:

Bug 1784624: baremetal: Enable the baremetal platform to override the default rhcos images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@kirankt: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-scaleup-rhel7 be61e07 link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

hardys pushed a commit to hardys/dev-scripts that referenced this pull request Dec 18, 2019
Convert OS Image cache to use new install-config interface
ac99596 
Since openshift/installer#2757
merged we can mirror the installer referenced images directly
to simulate typical disconnected install scenarios.

This removes some complexity as we no longer need to run the
downloader container on the host, only expose the unprocessed images
via http.

Note this will work with latest 4.4. builds but not 4.3 until
openshift/installer#2835 lands
This was referenced Dec 18, 2019
Merged
Closed
hardys pushed a commit to hardys/dev-scripts that referenced this pull request Dec 18, 2019
Convert OS Image cache to use new install-config interface
e13e469 
Since openshift/installer#2757
merged we can mirror the installer referenced images directly
to simulate typical disconnected install scenarios.

This removes some complexity as we no longer need to run the
downloader container on the host, only expose the unprocessed images
via http.

Note this will work with latest 4.4. builds but not 4.3 until
openshift/installer#2835 lands
hardys pushed a commit to hardys/dev-scripts that referenced this pull request Dec 19, 2019
Convert OS Image cache to use new install-config interface
0cc0558 
Since openshift/installer#2757
merged we can mirror the installer referenced images directly
to simulate typical disconnected install scenarios.

This removes some complexity as we no longer need to run the
downloader container on the host, only expose the unprocessed images
via http.

Note this will work with latest 4.4. builds but not 4.3 until
openshift/installer#2835 lands
@hardys hardys mentioned this pull request Jan 9, 2020
Closed
@stbenjam stbenjam mentioned this pull request Jan 15, 2020
Merged
@hardys hardys mentioned this pull request Jan 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhinavdahiya abhinavdahiya abhinavdahiya left review comments

@hardys hardys hardys left review comments

@stbenjam stbenjam stbenjam requested changes

@celebdor celebdor Awaiting requested review from celebdor

@jstuever jstuever Awaiting requested review from jstuever

Assignees

@stbenjam stbenjam

@abhinavdahiya abhinavdahiya

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. platform/baremetal IPI bare metal hosts platform size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@kirankt @openshift-ci-robot @stbenjam @metal3ci @hardys @abhinavdahiya @openshift-bot @openshift-cherrypick-robot @openshift-merge-robot