New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openstack UPI: Automate Security Group creation #2593

Merged

openshift-merge-robot merged 1 commit into openshift:master from pierreprinetti:os_upi_ansible_secgroups

Nov 25, 2019

Member

pierreprinetti commented Oct 30, 2019

Create an Ansible playbook for deploying the Security Groups required
for a User Provided Infrastructure installation.

Implements https://jira.coreos.com/browse/OSASINFRA-785

Depends on #2580

openshift-ci-robot added do-not-merge/work-in-progress size/L labels

openshift-ci-robot requested review from jhixson74 and jstuever

October 30, 2019 17:05

openshift-ci-robot added the approved label

pierreprinetti marked this pull request as ready for review

October 31, 2019 10:16

openshift-ci-robot removed the do-not-merge/work-in-progress label

Member Author

pierreprinetti commented Oct 31, 2019

/cc @Fedosin @tomassedovic @mandre

openshift-ci-robot requested review from Fedosin, mandre and tomassedovic

October 31, 2019 10:21

Member Author

pierreprinetti commented Oct 31, 2019

/label platform/openstack

openshift-ci-robot added the platform/openstack label


          openstack UPI: Automate Security Group creation

94a0ad5

Create an Ansible playbook for deploying the Security Groups required
for a User Provided Infrastructure installation.

Implements https://jira.coreos.com/browse/OSASINFRA-785

Member Author

pierreprinetti commented Nov 1, 2019

/retest

Member Author

pierreprinetti commented Nov 4, 2019 •

edited

Loading

/hold

While in Feature Freeze.

openshift-ci-robot added the do-not-merge/hold label

gageorsburn commented Nov 7, 2019

Curiosity question, why is this done with ansible and not terraform?

Member Author

pierreprinetti commented Nov 7, 2019

I believe it could have been either way; the RFE goes like this:

Ansible is a tool system administrators already tend to be familiar with

gageorsburn commented Nov 7, 2019

Thanks for the information!

Contributor

jstuever commented Nov 11, 2019

/uncc @jstuever

openshift-ci-robot removed the request for review from jstuever

November 11, 2019 18:50

Member Author

pierreprinetti commented Nov 22, 2019

/hold cancel

openshift-ci-robot removed the do-not-merge/hold label

iamemilio commented Nov 22, 2019

/retest

Contributor

tomassedovic commented Nov 25, 2019

/lgtm

openshift-ci-robot assigned tomassedovic

openshift-ci-robot added the lgtm label

Contributor

openshift-ci-robot commented Nov 25, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierreprinetti, tomassedovic

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~upi/openstack/OWNERS~~ [pierreprinetti,tomassedovic]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Contributor

openshift-bot commented Nov 25, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Nov 25, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments

Contributor

openshift-bot commented Nov 25, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Nov 25, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Nov 25, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Nov 25, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Nov 25, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Nov 25, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

Member Author

pierreprinetti commented Nov 25, 2019

Don't give up, @openshift-bot!

Contributor

openshift-bot commented Nov 25, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment

Contributor

openshift-bot commented Nov 25, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-merge-robot merged commit a9c3395 into openshift:master

Contributor

openshift-ci-robot commented Nov 25, 2019

@pierreprinetti: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws-scaleup-rhel7	`94a0ad5`	link	`/test e2e-aws-scaleup-rhel7`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

pierreprinetti deleted the os_upi_ansible_secgroups branch

November 27, 2019 09:51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm platform/openstack size/L