Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added memory/cpu variables for libvirt #257

Closed
wants to merge 1 commit into from
Closed

Added memory/cpu variables for libvirt #257

wants to merge 1 commit into from

Conversation

e-minguez
Copy link
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 17, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: e-minguez
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: steveej

If they are not already assigned, you can assign the PR to them by writing /assign @steveej in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@abhinavdahiya
Copy link
Contributor

@e-minguez any reason why the defaults are not enough? OR why you would want to change these values?

@eparis
Copy link
Member

eparis commented Sep 17, 2018

we actually ripped these out a while ago...

@wking
Copy link
Member

wking commented Sep 17, 2018

Cross linking #163, where we switched to the current hardcoded approach.

@crawford
Copy link
Contributor

We can re-open this if there is a good justification.

/close

@openshift-ci-robot
Copy link
Contributor

@crawford: Closing this PR.

In response to this:

We can re-open this if there is a good justification.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants