builder-run: Drop unused script #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
size/XL
This script is from f7103ba (build: add back builder-run utility script, 2017-05-09, coreos/tectonic-installer#609), but doesn't seem to have ever been used anywhere. With installer/scripts gone since 7296010 (frontend: Remove frontend code and backend API code, 2018-04-06, coreos/tectonic-installer#3067), I think we can just drop builder-run entirely.
wking
force-pushed
the
drop-builder-run
branch
from
1645b74 to
acd2791
Compare
openshift-ci-robot
added
size/S
Merged
|
/lgtm |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: crawford, eparis, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
1 similar comment
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This script is from f7103ba (coreos/tectonic-installer#609), but doesn't seem to have ever been used anywhere. With installer/scripts gone since 7296010 (coreos/tectonic-installer#3067), I think we can just drop
builder-runentirely.Spun off from this thread.