Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openstack: add tag and desc to bootstrap floating IP #2127

Merged
merged 1 commit into from
Aug 1, 2019
Merged

openstack: add tag and desc to bootstrap floating IP #2127

merged 1 commit into from
Aug 1, 2019

Conversation

dprince
Copy link
Contributor

@dprince dprince commented Jul 31, 2019 •
edited
Loading

Tag the floating IP with the cluster ID. Without it we are leaking floating IPs.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 31, 2019
@tomassedovic
Copy link
Contributor

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2019
@tomassedovic
Copy link
Contributor

@dprince Thanks!

This adds the right tag but it doesn't delete the bootstrap floating IP on cluster destroy (I've verified this locally as well). I think we'll have to add floating IP destroy functionality to the installer explicitly.

@tomassedovic
Copy link
Contributor

See e.g. here: https://github.com/openshift/installer/pull/1953/files

@dprince dprince force-pushed the tag_openstack_floatingip branch 2 times, most recently from 5321be0 to e7df1a0 Compare July 31, 2019 18:47
@dprince
Copy link
Contributor Author

dprince commented Jul 31, 2019

Watching the CI job. I see the description now shows up as: ci-op-5mb3ifky-lj526-bootstrap-fip.

Which means the CI job will find and delete it shortly :)

@dprince dprince force-pushed the tag_openstack_floatingip branch from e7df1a0 to bed2173 Compare July 31, 2019 19:30
@dprince dprince changed the title openstack: tag new floating ip openstack: add tag and desc to bootstrap floating IP Jul 31, 2019
@Fedosin
Copy link
Contributor

Fedosin commented Jul 31, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprince, Fedosin, tomassedovic

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@dprince
Copy link
Contributor Author

dprince commented Aug 1, 2019

/retest

@iamemilio
Copy link

/test e2e-aws-scaleup-rhel7

@openshift-merge-robot openshift-merge-robot merged commit a7807f0 into openshift:master Aug 1, 2019
@openshift-ci-robot
Copy link
Contributor

@dprince: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-scaleup-rhel7 bed2173 link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhixson74 jhixson74 Awaiting requested review from jhixson74

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

Assignees

@Fedosin Fedosin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@dprince @tomassedovic @Fedosin @openshift-ci-robot @openshift-bot @iamemilio @openshift-merge-robot