*: Replace '$(pwd)' with '${PWD}' #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
size/S
wking
force-pushed
the
pwd-process-to-env-var
branch
from
1c6deec to
e9f768e
Compare
wking
commented
Aug 29, 2018
| @@ -5,7 +5,7 @@ echo "Rendering Kubernetes core manifests..." | |||
|
|
|||
| # shellcheck disable=SC2154 | |||
| /usr/bin/docker run \ | |||
| --volume "$(pwd)":/assets:z \ | |||
| --volume "${PWD}:/assets:z" \ | |||
There was a problem hiding this comment.
Hmm, this may not play well with template replacement (e.g. see the $$ further down).
PWD is in POSIX [1], so there's no need to execute a pwd process to
get this value. This fixes everthing found by:
$ git grep '\(pwd\)'
except for hack/*.sh, which is being addressed by [2].
I'm using $PWD instead of ${PWD} in the module files to avoid them
being interpolated [3] on template rendering [4].
[1]: http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap08.html#tag_08_03
[2]: openshift#174
[3]: https://www.terraform.io/docs/configuration/interpolation.html
[4]: https://www.terraform.io/docs/providers/template/d/file.html
wking
force-pushed
the
pwd-process-to-env-var
branch
from
e9f768e to
a480782
Compare
|
retest this please |
|
The e2e-aws error was: /retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PWDis in POSIX, so there's no need to execute apwdprocess to get this value. This fixes everthing found by:$ git grep '\(pwd\)'except for
hack/*.sh, which is being addressed by #174.